Skip to content

Updated source name for telemetry #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lu-ohai merged 26 commits into from
Apr 22, 2024
Merged

Updated source name for telemetry #781

lu-ohai merged 26 commits into from
Apr 22, 2024

Conversation

@lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Apr 17, 2024

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 17, 2024
@github-actions
Copy link

github-actions bot commented Apr 17, 2024

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-21.34%

@github-actions
Copy link

github-actions bot commented Apr 17, 2024

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-60.70%

VipulMascarenhas
VipulMascarenhas reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one minor comment to remove is_valid_ocid check. Also, you can update this PR to merge to feature/aquav1.0.1 branch.

@lu-ohai lu-ohai changed the base branch from main to feature/aquav1.0.1 April 17, 2024 21:08
@qiuosier
Copy link
Member

qiuosier commented Apr 18, 2024

Could you do the same update for fine-tuning? We may want to support fine-tuning custom models in the future.

@lu-ohai
Copy link
Member Author

lu-ohai commented Apr 18, 2024

Could you do the same update for fine-tuning? We may want to support fine-tuning custom models in the future.

Do we have a design for this already? If we support custom model, does it also copied from service model? Also, will the custom model has a specific tag to tell from service model? @qiuosier

@VipulMascarenhas
Copy link
Member

VipulMascarenhas commented Apr 22, 2024

Could you do the same update for fine-tuning? We may want to support fine-tuning custom models in the future.

Do we have a design for this already? If we support custom model, does it also copied from service model? Also, will the custom model has a specific tag to tell from service model? @qiuosier

@lu-ohai let's add fine-tuning one in a separate PR.

@lu-ohai lu-ohai merged commit 2d74979 into feature/aquav1.0.1 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VipulMascarenhas VipulMascarenhas VipulMascarenhas approved these changes

@darenr darenr Awaiting requested review from darenr

@mayoor mayoor Awaiting requested review from mayoor

@mrDzurb mrDzurb Awaiting requested review from mrDzurb

@qiuosier qiuosier Awaiting requested review from qiuosier

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lu-ohai @qiuosier @VipulMascarenhas @mrDzurb @mingkang111