Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
621e277
show extension for default region
VipulMascarenhas Apr 16, 2024
a508b68
space issue
VipulMascarenhas Apr 16, 2024
c2fa183
Updated source name for telemetry.
lu-ohai Apr 17, 2024
7eee820
Updated pr,
lu-ohai Apr 17, 2024
ec4c615
Merge branch 'main' into ODSC-55771/fix_telemetry_name
lu-ohai Apr 17, 2024
8dd0704
change assert statements
VipulMascarenhas Apr 17, 2024
31c77fb
Added default compartment id for evaluation list.
lu-ohai Apr 17, 2024
0efe6fd
Adds supporting BLEU score metric for evaluation.
mrDzurb Apr 18, 2024
afea502
update md telemetry
VipulMascarenhas Apr 18, 2024
3e7fd13
Improvements on handling error raised in AQUA
mingkang111 Apr 18, 2024
ea86a9e
resolve merge conflicts
VipulMascarenhas Apr 18, 2024
7a9d905
Adds supporting BLEU score metric for evaluation. (#784)
mrDzurb Apr 18, 2024
9c71915
Merge branch 'main' into feature/aquav1.0.1
VipulMascarenhas Apr 18, 2024
2915053
Added support to force overwrite extsing file in object storage.
lu-ohai Apr 18, 2024
5f20ec3
Added support to force overwrite extsing file in object storage. (#789)
lu-ohai Apr 18, 2024
746534e
[ODSC-56061] Update Model deployment telemetry (#785)
VipulMascarenhas Apr 18, 2024
5ffb5de
update error message
VipulMascarenhas Apr 18, 2024
f5f2168
Added default compartment id for evaluation list. (#783)
lu-ohai Apr 18, 2024
82d011c
Update error message for create method failure (#792)
VipulMascarenhas Apr 18, 2024
88bb9c6
review comments
VipulMascarenhas Apr 18, 2024
c424a09
[ODSC-55513] Show Aqua extension for the default region (#778)
VipulMascarenhas Apr 19, 2024
a4e36a9
Add test cases for checking content decoding (#791)
mingkang111 Apr 19, 2024
ff217d8
Updated comment.
lu-ohai Apr 19, 2024
90e01a4
Merge branch 'feature/aquav1.0.1' of https://github.com/oracle/accele…
lu-ohai Apr 19, 2024
2fdadef
Merge branch 'ODSC-55771/fix_telemetry_name' of https://github.com/or…
lu-ohai Apr 19, 2024
a019df8
Merge branch 'feature/aquav1.0.1' into ODSC-55771/fix_telemetry_name
lu-ohai Apr 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion ads/aqua/evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
JOB_INFRASTRUCTURE_TYPE_DEFAULT_NETWORKING,
NB_SESSION_IDENTIFIER,
UNKNOWN,
extract_id_and_name_from_tag,
fire_and_forget,
get_container_image,
is_valid_ocid,
Expand Down Expand Up @@ -686,7 +687,7 @@ def create(
self.telemetry.record_event_async(
category="aqua/evaluation",
action="create",
detail=evaluation_source.display_name,
detail=self._get_service_model_name(evaluation_source),
)

return AquaEvaluationSummary(
Expand Down Expand Up @@ -776,6 +777,34 @@ def _build_evaluation_runtime(
)

return runtime

@staticmethod
def _get_service_model_name(
source: Union[ModelDeployment, DataScienceModel]
) -> str:
"""Gets the service model name from source. If it's ModelDeployment, needs to check
if its model has been fine tuned or not.

Parameters
----------
source: Union[ModelDeployment, DataScienceModel]
An instance of either ModelDeployment or DataScienceModel

Returns
-------
str:
The service model name of source.
"""
if isinstance(source, ModelDeployment):
fine_tuned_model_tag = source.freeform_tags.get(
Tags.AQUA_FINE_TUNED_MODEL_TAG.value, UNKNOWN
)
if not fine_tuned_model_tag:
return source.freeform_tags.get(Tags.AQUA_MODEL_NAME_TAG.value)
else:
return extract_id_and_name_from_tag(fine_tuned_model_tag)[1]

return source.display_name

@staticmethod
def _get_evaluation_container(source_id: str) -> str:
Expand Down
1 change: 1 addition & 0 deletions ads/aqua/finetune.py
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ def create(
**telemetry_kwargs,
)
# tracks unique fine-tuned models that were created in the user compartment
# TODO: retrieve the service model name for FT custom models.
self.telemetry.record_event_async(
category="aqua/service/finetune",
action="create",
Expand Down
39 changes: 38 additions & 1 deletion tests/unitary/with_extras/aqua/test_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from parameterized import parameterized

from ads.aqua import utils
from ads.aqua.data import Tags
from ads.aqua.evaluation import (
AquaEvalMetrics,
AquaEvalReport,
Expand All @@ -28,9 +29,10 @@
AquaRuntimeError,
)
from ads.aqua.extension.base_handler import AquaAPIhandler
from ads.aqua.utils import EVALUATION_REPORT_JSON, EVALUATION_REPORT_MD
from ads.aqua.utils import EVALUATION_REPORT_JSON, EVALUATION_REPORT_MD, UNKNOWN
from ads.jobs.ads_job import DataScienceJob, DataScienceJobRun, Job
from ads.model import DataScienceModel
from ads.model.deployment.model_deployment import ModelDeployment
from ads.model.model_version_set import ModelVersionSet

null = None
Expand Down Expand Up @@ -523,6 +525,41 @@ def test_create_evaluation(
"time_created": f"{oci_dsc_model.time_created}",
}

def test_get_service_model_name(self):
# get service model name from fine tuned model deployment
source = (
ModelDeployment()
.with_freeform_tags(
**{
Tags.AQUA_TAG.value: UNKNOWN,
Tags.AQUA_FINE_TUNED_MODEL_TAG.value: "test_service_model_id#test_service_model_name",
Tags.AQUA_MODEL_NAME_TAG.value: "test_fine_tuned_model_name"
}
)
)
service_model_name = self.app._get_service_model_name(source)
assert service_model_name == "test_service_model_name"

# get service model name from model deployment
source = (
ModelDeployment()
.with_freeform_tags(
**{
Tags.AQUA_TAG.value: "active",
Tags.AQUA_MODEL_NAME_TAG.value: "test_service_model_name"
}
)
)
service_model_name = self.app._get_service_model_name(source)
assert service_model_name == "test_service_model_name"

# get service model name from service model
source = DataScienceModel(
display_name="test_service_model_name"
)
service_model_name = self.app._get_service_model_name(source)
assert service_model_name == "test_service_model_name"

@parameterized.expand(
[
(
Expand Down