JAVAVSCODE-863: Notebook project context does not appear to be working on windows - #617
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
singh-akhilesh
requested review from
Achal1607 and
sid-srini
and removed request for
Achal1607
June 23, 2026 13:21
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
June 24, 2026 04:06
36daf1b to
ac69431
Compare
singh-akhilesh
changed the title
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
June 24, 2026 05:31
ac69431 to
0fc9268
Compare
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
June 30, 2026 06:33
0fc9268 to
e846c3b
Compare
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
June 30, 2026 11:09
e846c3b to
1d29e94
Compare
sid-srini
requested changes
Jul 17, 2026
sid-srini
left a comment
sid-srini
left a comment
Member
There was a problem hiding this comment.
Thanks @singh-akhilesh for fixing these issues.
Please address the minor comment about localisation. Otherwise, LGTM 👍
Thanks
|
|
||
| const yes = l10n.value("jdk.extension.cache.label.confirmation.yes") | ||
| const cancel = l10n.value("jdk.extension.cache.label.confirmation.cancel") | ||
| const confirmation = await window.showWarningMessage("Project context changed. Do you want to restart the notebook kernel?", |
Member
There was a problem hiding this comment.
Please add this message in the l10n/bundle.l10n.*.json files with a message key and use l10n.value(<messageKey>) here. Thanks.
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
July 20, 2026 06:10
1d29e94 to
79f0d4e
Compare
… the current-project-context text box.
singh-akhilesh
force-pushed
the
JAVAVSCODE-863
branch
from
July 20, 2026 06:58
79f0d4e to
2c8aab5
Compare
sid-srini
approved these changes
Jul 20, 2026
sid-srini
left a comment
sid-srini
left a comment
Member
There was a problem hiding this comment.
Thanks @singh-akhilesh. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows-only notebook project-context issue where an .ijnb file of the Java project unable to resolves the project context correctly in the dropdown/settings.