Skip to content

Conversation

@idodeclare
Copy link
Contributor

Hello,

Please consider for integration this patch to fix the bulk operations that are slow when the project count in the thousands (Select-All, Invert-Selection, Clear) by adding a Map by val() and also avoiding creating HTML elements when exceeding a defined maxShow.

When a bulk operation is in-progress, the X-Items-Selected update is deferred and only done at the end of the operation.

I encountered one testing problem which I need advice for: I was running with a thousand test projects, but my system could not actually support a query for all 1000 projects, and it showed a page with just 0. On hitting Back, the page was not in a consistent state, and Select-All, Invert-Selection, and Clear did not work as expected. Any advice?

Thank you.

@tarzanek
Copy link
Contributor

lgtm, +1 for merge

@tarzanek tarzanek merged commit c8f98ae into oracle:master Apr 13, 2020
@idodeclare idodeclare deleted the bugfix/slow_sol branch April 13, 2020 13:51
@idodeclare
Copy link
Contributor Author

Ohhhhhhhhhh sorry I introduced a bug. When the SOL is being bound by maxShow, and you X a shown item, another selected item should be shown — but I removed that bit not understanding. Luckily this is for the non-bulk UI, so let me see about effectively restoring that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants