Fix #1665 : searchable-option-list bulk operations are slow #3112
+78
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to fix the bulk operations that are slow when the project count in the thousands (
Select-All,Invert-Selection,Clear) by adding aMapbyval()and also avoiding creating HTML elements when exceeding a definedmaxShow.When a bulk operation is in-progress, the
X-Items-Selectedupdate is deferred and only done at the end of the operation.I encountered one testing problem which I need advice for: I was running with a thousand test projects, but my system could not actually support a query for all 1000 projects, and it showed a page with just
0. On hitting Back, the page was not in a consistent state, andSelect-All,Invert-Selection, andCleardid not work as expected. Any advice?Thank you.