cpplint: Extract the fork cpplint/cpplint from google/styleguide #155055
Select Topic AreaQuestion Body
|
Replies: 7 comments 3 replies
|
As mentioned in the issue, our main motivation for uncoupling is to make the default PR target our repo instead of the Google style guide repo. If there's another way to do that for PRs from branches on our repo, that should also solve the problem. |
|
I believe detaching will not effect the |
|
Hey @jayvdb and @aaronliu0130 , I get that you want to decouple cpplint from the Google styleguide repo to make your repo the default PR target, but detaching the fork directly will indeed wipe out all issues, PRs, stars, and other metadata, as @aaronliu0130 pointed out. That’s not ideal since cpplint has a lot of history you’d want to keep. Instead of detaching, you can change the default PR. |
|
How do we "change the default PR"? |
|
Hey @cclauss, sorry I just realized I sort of circled back to the same discussion when I mentioned changing the default PR target, I meant making cpplint/cpplint the "base repository" in the fork network so PRs default to your repo instead of google/styleguide. I believe this can be done by contacting GitHub Support (https://support.github.com/contact), explain that cpplint/cpplint (with 300k+ downloads a month) has diverged significantly and should be the new base of the fork network, and they can reassign it for you. This keeps all your issues, PRs, and history intact while solving the PR target issue. Let me know if that sounds feasible . |
|
extracting the fork is definitely the right move—it’ll make cpplint/cpplint the new root, so PRs will default to your repo, and you won’t lose any history. Once Support finishes, just check that PRs are targeting cpplint/cpplint and maybe update the README to let everyone know about the change. hope it helped have a great time.. |
|
It is done! https://github.com/cpplint/cpplint |
Hey @cclauss, sorry I just realized I sort of circled back to the same discussion when I mentioned changing the default PR target, I meant making cpplint/cpplint the "base repository" in the fork network so PRs default to your repo instead of google/styleguide. I believe this can be done by contacting GitHub Support (https://support.github.com/contact), explain that cpplint/cpplint (with 300k+ downloads a month) has diverged significantly and should be the new base of the fork network, and they can reassign it for you. This keeps all your issues, PRs, and history intact while solving the PR target issue. Let me know if that sounds feasible .