Skip to content

fix: add namespace to hydra poddisruptionbudget helm template (#885) - #885

Merged
Demonsthere merged 4 commits into
ory:masterfrom
naohiroo:fix/hydra-add-namespace-to-poddisruptionbudget
Jul 2, 2026
Merged

fix: add namespace to hydra poddisruptionbudget helm template (#885)#885
Demonsthere merged 4 commits into
ory:masterfrom
naohiroo:fix/hydra-add-namespace-to-poddisruptionbudget

Conversation

@naohiroo

@naohiroo naohiroo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Related Issue or Design Document

#884

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Improved deployment configuration by setting the namespace for disruption budget resources when available, helping them render correctly in namespaced installs.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c2a75e2-9e32-4d31-80a8-230223075e70

📥 Commits

Reviewing files that changed from the base of the PR and between a99387e and 130ae33.

📒 Files selected for processing (1)
  • helm/charts/hydra/templates/pdb.yaml

📝 Walkthrough

Walkthrough

The PodDisruptionBudget Helm template for the Hydra chart now conditionally includes a metadata.namespace field, set to .Release.Namespace when that value is present.

Changes

Hydra PDB Namespace Fix

Layer / File(s) Summary
Conditional namespace in PDB template
helm/charts/hydra/templates/pdb.yaml
Adds a conditional block that emits namespace: {{ .Release.Namespace }} under metadata only when .Release.Namespace is set.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

Possibly related PRs

  • ory/k8s#874: Adds the same conditional metadata.namespace pattern to another Hydra manifest (Deployment).

Suggested reviewers: Demonsthere, piotrmsc

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the issue reference and checklist, but the big-picture summary and further comments are left as placeholders. Add a short summary of why the namespace field is needed, the user impact, and any tests or docs relevant to the fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: it says the Hydra PDB Helm template adds a namespace, which is the main modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@naohiroo
naohiroo marked this pull request as ready for review July 1, 2026 12:30
@Demonsthere
Demonsthere merged commit e4021bf into ory:master Jul 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants