Revert "Update osac repo's required status check for CaaS Netris rename" - #168
Merged
Merged
Conversation
This reverts commit 2a0da0f.
WalkthroughThe Changesrepo_osac status check
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@repositories.tf`:
- Line 150: Update the required status context entry in repositories.tf from
“e2e-caas-full-install / e2e” to “e2e-caas-netris-full-install / e2e”,
preserving the existing integration_id and surrounding configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 74b31426-bef1-42bc-a8be-58278fadab4c
📒 Files selected for processing (1)
repositories.tf
| { context = "e2e-vmaas-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-bmaas-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-caas-netris-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-caas-full-install / e2e", integration_id = 15368 }, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 8 \
'e2e-caas-full-install|e2e-caas-netris-full-install|integration_id\s*=\s*15368|name:\s*e2e' \
--glob '*.tf' --glob '*.yml' --glob '*.yaml' .Repository: osac-project/github-config
Length of output: 5846
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- candidate workflow and configuration files ---'
git ls-files | rg '(^|/)(\.github/workflows/|.*\.(ya?ml|tf)$)' | sed -n '1,240p'
printf '%s\n' '--- all repository references to the required contexts ---'
rg -n -C 5 \
'e2e-(vmaas|bmaas|caas)-full-install|integration_id\s*=\s*15368|OSAC|osac-ci|workflow_call|name:\s*e2e' \
. --glob '!**/.git/**' | sed -n '1,320p'
printf '%s\n' '--- recent commit subjects and trailers ---'
git log -8 --format='%H%n%B%n---' | sed -n '1,240p'Repository: osac-project/github-config
Length of output: 17147
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- affected commits and parent state ---'
git show --no-ext-diff --format=fuller --stat c7d36ef8684901c9d2e6793bf84a73fcff7ee8f
git show --no-ext-diff --format= --unified=12 c7d36ef8684901c9d2e6793bf84a73fcff7ee8f -- repositories.tf
git show --no-ext-diff --format= --unified=12 2a0da0f0759ea5a6101425737131052ce229bd85 -- repositories.tf
printf '%s\n' '--- osac workflow files ---'
curl --fail --silent --show-error \
-H 'Accept: application/vnd.github+json' \
https://api.github.com/repos/osac-project/osac/contents/.github/workflows \
| jq -r '.[].name' | sort
printf '%s\n' '--- CaaS workflow definitions ---'
for file in e2e-caas-full-install.yml e2e-caas-netris-full-install.yml; do
url="https://raw.githubusercontent.com/osac-project/osac/main/.github/workflows/$file"
printf '\n--- %s ---\n' "$file"
curl --silent --show-error --fail "$url" \
| nl -ba \
| rg -n -C 8 '^( *[0-9]+\s+)?\s*(name:|jobs:|[A-Za-z0-9_-]+:|run:|uses:|workflow_call:)' \
| sed -n '1,260p' || printf 'not present\n'
doneRepository: osac-project/github-config
Length of output: 3544
🏁 Script executed:
#!/bin/bash
set -u
for ref in main master; do
for file in e2e-caas-full-install.yml e2e-caas-netris-full-install.yml; do
url="https://raw.githubusercontent.com/osac-project/osac/$ref/.github/workflows/$file"
printf '\n--- %s %s ---\n' "$ref" "$file"
if curl --silent --show-error --location --fail "$url" -o /tmp/osac-workflow.yml; then
cat -n /tmp/osac-workflow.yml \
| rg -n -C 12 'name:|jobs:|e2e|netris|^ *[A-Za-z0-9_-]+:' \
| sed -n '1,320p'
else
printf 'not available\n'
fi
done
done
printf '\n--- referenced pull request metadata ---\n'
curl --silent --show-error --location \
'https://github.com/osac-project/osac/pull/110.patch' \
| sed -n '1,220p'Repository: osac-project/github-config
Length of output: 20507
🏁 Script executed:
#!/bin/bash
set -euo pipefail
workflow_url='https://raw.githubusercontent.com/osac-project/osac/main/.github/workflows/e2e-caas-netris-full-install.yml'
curl --silent --show-error --location --fail "$workflow_url" -o /tmp/e2e-caas-netris-full-install.yml
python3 - <<'PY'
import re
from pathlib import Path
text = Path('/tmp/e2e-caas-netris-full-install.yml').read_text()
workflow_name = re.search(r'^name:\s*(.+)$', text, re.MULTILINE).group(1)
job_names = re.findall(r'^ ([A-Za-z0-9_-]+):\s*$', text, re.MULTILINE)
e2e_block = re.search(r'^ e2e:\s*$([\s\S]*?)(?=^ [A-Za-z0-9_-]+:\s*$|\Z)', text, re.MULTILINE)
print(f'workflow name: {workflow_name}')
print(f'job names: {job_names}')
print(f'gating job present: {bool(e2e_block)}')
if e2e_block:
print('gating job needs:', re.search(r'^\s*needs:\s*(.+)$', e2e_block.group(1), re.MULTILINE).group(1))
print('old CaaS job present:', bool(re.search(r'^ e2e-caas-full-install:\s*$', text, re.MULTILINE)))
print('Netris CaaS job present:', bool(re.search(r'^ e2e-caas-netris-full-install:\s*$', text, re.MULTILINE)))
PY
printf '%s\n' '--- trailers for the affected github-config commits ---'
for commit in c7d36ef8684901c9d2e6793bf84a73fcff7ee8f 2a0da0f0759ea5a6101425737131052ce229bd85; do
printf '\ncommit %s\n' "$commit"
git show -s --format='%B' "$commit" | sed -n '/^Signed-off-by:/p;/^Assisted-by:/p;/^Generated-by:/p;/^Co-Authored-By:/p'
doneRepository: osac-project/github-config
Length of output: 673
Change the required CaaS check to e2e-caas-netris-full-install / e2e. The osac repository removed the old workflow and now exposes the Netris workflow with the e2e gating job. The current context will never report and will block pull requests.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@repositories.tf` at line 150, Update the required status context entry in
repositories.tf from “e2e-caas-full-install / e2e” to
“e2e-caas-netris-full-install / e2e”, preserving the existing integration_id and
surrounding configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netris Job is still not stable and blocking PRs reverting #166
Summary by CodeRabbit
repo_osacto use the current end-to-end installation check.