Skip to content

Revert "Update osac repo's required status check for CaaS Netris rename" #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliorerz merged 1 commit into from
Aug 5, 2026
Merged

Revert "Update osac repo's required status check for CaaS Netris rename" #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repositories.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ module "repo_osac" {
required_status_checks = [
{ context = "e2e-vmaas-full-install / e2e", integration_id = 15368 },
{ context = "e2e-bmaas-full-install / e2e", integration_id = 15368 },
{ context = "e2e-caas-netris-full-install / e2e", integration_id = 15368 },
{ context = "e2e-caas-full-install / e2e", integration_id = 15368 },

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n -C 8 \
  'e2e-caas-full-install|e2e-caas-netris-full-install|integration_id\s*=\s*15368|name:\s*e2e' \
  --glob '*.tf' --glob '*.yml' --glob '*.yaml' .

Repository: osac-project/github-config

Length of output: 5846

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- candidate workflow and configuration files ---'
git ls-files | rg '(^|/)(\.github/workflows/|.*\.(ya?ml|tf)$)' | sed -n '1,240p'

printf '%s\n' '--- all repository references to the required contexts ---'
rg -n -C 5 \
  'e2e-(vmaas|bmaas|caas)-full-install|integration_id\s*=\s*15368|OSAC|osac-ci|workflow_call|name:\s*e2e' \
  . --glob '!**/.git/**' | sed -n '1,320p'

printf '%s\n' '--- recent commit subjects and trailers ---'
git log -8 --format='%H%n%B%n---' | sed -n '1,240p'

Repository: osac-project/github-config

Length of output: 17147

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- affected commits and parent state ---'
git show --no-ext-diff --format=fuller --stat c7d36ef8684901c9d2e6793bf84a73fcff7ee8f
git show --no-ext-diff --format= --unified=12 c7d36ef8684901c9d2e6793bf84a73fcff7ee8f -- repositories.tf
git show --no-ext-diff --format= --unified=12 2a0da0f0759ea5a6101425737131052ce229bd85 -- repositories.tf

printf '%s\n' '--- osac workflow files ---'
curl --fail --silent --show-error \
  -H 'Accept: application/vnd.github+json' \
  https://api.github.com/repos/osac-project/osac/contents/.github/workflows \
  | jq -r '.[].name' | sort

printf '%s\n' '--- CaaS workflow definitions ---'
for file in e2e-caas-full-install.yml e2e-caas-netris-full-install.yml; do
  url="https://raw.githubusercontent.com/osac-project/osac/main/.github/workflows/$file"
  printf '\n--- %s ---\n' "$file"
  curl --silent --show-error --fail "$url" \
    | nl -ba \
    | rg -n -C 8 '^( *[0-9]+\s+)?\s*(name:|jobs:|[A-Za-z0-9_-]+:|run:|uses:|workflow_call:)' \
    | sed -n '1,260p' || printf 'not present\n'
done

Repository: osac-project/github-config

Length of output: 3544

🏁 Script executed:

#!/bin/bash
set -u

for ref in main master; do
  for file in e2e-caas-full-install.yml e2e-caas-netris-full-install.yml; do
    url="https://raw.githubusercontent.com/osac-project/osac/$ref/.github/workflows/$file"
    printf '\n--- %s %s ---\n' "$ref" "$file"
    if curl --silent --show-error --location --fail "$url" -o /tmp/osac-workflow.yml; then
      cat -n /tmp/osac-workflow.yml \
        | rg -n -C 12 'name:|jobs:|e2e|netris|^ *[A-Za-z0-9_-]+:' \
        | sed -n '1,320p'
    else
      printf 'not available\n'
    fi
  done
done

printf '\n--- referenced pull request metadata ---\n'
curl --silent --show-error --location \
  'https://github.com/osac-project/osac/pull/110.patch' \
  | sed -n '1,220p'

Repository: osac-project/github-config

Length of output: 20507

🏁 Script executed:

#!/bin/bash
set -euo pipefail

workflow_url='https://raw.githubusercontent.com/osac-project/osac/main/.github/workflows/e2e-caas-netris-full-install.yml'
curl --silent --show-error --location --fail "$workflow_url" -o /tmp/e2e-caas-netris-full-install.yml

python3 - <<'PY'
import re
from pathlib import Path

text = Path('/tmp/e2e-caas-netris-full-install.yml').read_text()
workflow_name = re.search(r'^name:\s*(.+)$', text, re.MULTILINE).group(1)
job_names = re.findall(r'^  ([A-Za-z0-9_-]+):\s*$', text, re.MULTILINE)
e2e_block = re.search(r'^  e2e:\s*$([\s\S]*?)(?=^  [A-Za-z0-9_-]+:\s*$|\Z)', text, re.MULTILINE)

print(f'workflow name: {workflow_name}')
print(f'job names: {job_names}')
print(f'gating job present: {bool(e2e_block)}')
if e2e_block:
    print('gating job needs:', re.search(r'^\s*needs:\s*(.+)$', e2e_block.group(1), re.MULTILINE).group(1))
print('old CaaS job present:', bool(re.search(r'^  e2e-caas-full-install:\s*$', text, re.MULTILINE)))
print('Netris CaaS job present:', bool(re.search(r'^  e2e-caas-netris-full-install:\s*$', text, re.MULTILINE)))
PY

printf '%s\n' '--- trailers for the affected github-config commits ---'
for commit in c7d36ef8684901c9d2e6793bf84a73fcff7ee8f 2a0da0f0759ea5a6101425737131052ce229bd85; do
  printf '\ncommit %s\n' "$commit"
  git show -s --format='%B' "$commit" | sed -n '/^Signed-off-by:/p;/^Assisted-by:/p;/^Generated-by:/p;/^Co-Authored-By:/p'
done

Repository: osac-project/github-config

Length of output: 673

Change the required CaaS check to e2e-caas-netris-full-install / e2e. The osac repository removed the old workflow and now exposes the Netris workflow with the e2e gating job. The current context will never report and will block pull requests.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@repositories.tf` at line 150, Update the required status context entry in
repositories.tf from “e2e-caas-full-install / e2e” to
“e2e-caas-netris-full-install / e2e”, preserving the existing integration_id and
surrounding configuration.

]
# Preserve subtree-merge history/blame going forward -- squash-merging on the
# mono-repo would collapse that history for every commit after cutover, so
Expand Down
Loading