Fix TypeError in sync_ironic by adding missing request_id parameter#1849
Merged
Fix TypeError in sync_ironic by adding missing request_id parameter#1849
Conversation
Two calls to push_task_output() were missing the required request_id parameter, causing "missing 1 required positional argument: 'line'" errors. - Fixed line 232: Added request_id parameter for node removal failure message - Fixed line 396: Added request_id parameter for lock acquisition failure message - Changed line 396 to use f-string for proper device.name interpolation AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two calls to push_task_output() were missing the required request_id parameter, causing "missing 1 required positional argument: 'line'" errors.
AI-assisted: Claude Code