Skip to content

Fix TypeError in sync_ironic by adding missing request_id parameter #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berendt merged 1 commit into from
Nov 24, 2025
Merged

Fix TypeError in sync_ironic by adding missing request_id parameter #1849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions osism/tasks/conductor/ironic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ def sync_ironic(request_id, get_ironic_parameters, node_name=None, force=False):
openstack.baremetal_node_delete(node["uuid"])
else:
osism_utils.push_task_output(
f"Cannot remove baremetal node because it is still provisioned or running: {node}"
request_id,
f"Cannot remove baremetal node because it is still provisioned or running: {node}\n",
)

# NOTE: Find nodes in NetBox which are not present in Ironic and add them
Expand Down Expand Up @@ -394,7 +395,7 @@ def sync_ironic(request_id, get_ironic_parameters, node_name=None, force=False):

else:
osism_utils.push_task_output(
"Could not acquire lock for node {device.name}"
request_id, f"Could not acquire lock for node {device.name}\n"
)

osism_utils.finish_task_output(request_id, rc=0)
Expand Down