Use setup_cloud_environment() for OpenStack connections in manage com…#1900
Merged
Use setup_cloud_environment() for OpenStack connections in manage com…#1900
Conversation
…mands Replace direct get_cloud_connection() calls with setup_cloud_environment() and cleanup_cloud_environment() pattern in all manage commands. This ensures proper cloud configuration by: - Copying /etc/openstack/clouds.yaml to /tmp - Loading passwords securely from vault via get_cloud_password() - Creating /tmp/secure.yml with decrypted credentials - Properly cleaning up temporary files after execution Affected commands: - manage loadbalancer list/reset/delete - manage amphora restore/rotate - manage volume list/repair - manage server migrate/list/clean Also adds --cloud parameter to ServerMigrate for consistency. AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mands
Replace direct get_cloud_connection() calls with setup_cloud_environment() and cleanup_cloud_environment() pattern in all manage commands. This ensures proper cloud configuration by:
Affected commands:
Also adds --cloud parameter to ServerMigrate for consistency.
AI-assisted: Claude Code