Skip to content

Use setup_cloud_environment() for OpenStack connections in manage com… #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berendt merged 1 commit into from
Dec 5, 2025
Merged

Use setup_cloud_environment() for OpenStack connections in manage com… #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 71 additions & 53 deletions osism/commands/amphora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
from loguru import logger
import openstack

from osism.commands import get_cloud_connection
from osism.commands.octavia import wait_for_amphora_boot, wait_for_amphora_delete
from osism.tasks.openstack import cleanup_cloud_environment, setup_cloud_environment

# Default age threshold for rotation (30 days in seconds)
DEFAULT_ROTATION_AGE_SECONDS = 2592000
Expand Down Expand Up @@ -38,24 +38,32 @@ def take_action(self, parsed_args):
cloud = parsed_args.cloud
loadbalancer_id = parsed_args.loadbalancer

conn = get_cloud_connection(cloud)
temp_files, original_cwd, success = setup_cloud_environment(cloud)
if not success:
logger.error(f"Failed to setup cloud environment for '{cloud}'")
return 1

if loadbalancer_id:
amphorae = conn.load_balancer.amphorae(
status="ERROR", loadbalancer_id=loadbalancer_id
)
else:
amphorae = conn.load_balancer.amphorae(status="ERROR")
try:
conn = openstack.connect(cloud=cloud)

for amphora in amphorae:
logger.info(
f"Amphora {amphora.id} of loadbalancer {amphora.loadbalancer_id} is in state ERROR, trigger amphora failover"
)
conn.load_balancer.failover_amphora(amphora.id)
sleep(10) # wait for the octavia API
if loadbalancer_id:
amphorae = conn.load_balancer.amphorae(
status="ERROR", loadbalancer_id=loadbalancer_id
)
else:
amphorae = conn.load_balancer.amphorae(status="ERROR")

for amphora in amphorae:
logger.info(
f"Amphora {amphora.id} of loadbalancer {amphora.loadbalancer_id} is in state ERROR, trigger amphora failover"
)
conn.load_balancer.failover_amphora(amphora.id)
sleep(10) # wait for the octavia API

wait_for_amphora_boot(conn, amphora.loadbalancer_id)
wait_for_amphora_delete(conn, amphora.loadbalancer_id)
wait_for_amphora_boot(conn, amphora.loadbalancer_id)
wait_for_amphora_delete(conn, amphora.loadbalancer_id)
finally:
cleanup_cloud_environment(temp_files, original_cwd)


class AmphoraRotate(Command):
Expand Down Expand Up @@ -88,48 +96,58 @@ def take_action(self, parsed_args):
loadbalancer_id = parsed_args.loadbalancer
force = parsed_args.force

conn = get_cloud_connection(cloud)

done = []
temp_files, original_cwd, success = setup_cloud_environment(cloud)
if not success:
logger.error(f"Failed to setup cloud environment for '{cloud}'")
return 1

if loadbalancer_id:
amphorae = conn.load_balancer.amphorae(
status="ALLOCATED", loadbalancer_id=loadbalancer_id
)
else:
amphorae = conn.load_balancer.amphorae(status="ALLOCATED")
try:
conn = openstack.connect(cloud=cloud)

for amphora in amphorae:
rotate = False
done = []

if amphora.loadbalancer_id in done:
continue

duration = datetime.now(timezone.utc) - dateutil_parser.parse(
amphora.created_at
)
if duration.total_seconds() > DEFAULT_ROTATION_AGE_SECONDS:
logger.info(f"Amphora {amphora.id} is older than 30 days")
rotate = True
elif force:
logger.info(f"Force rotation of Amphora {amphora.id}")
rotate = True
if loadbalancer_id:
amphorae = conn.load_balancer.amphorae(
status="ALLOCATED", loadbalancer_id=loadbalancer_id
)
else:
continue
amphorae = conn.load_balancer.amphorae(status="ALLOCATED")

if rotate:
logger.info(
f"Amphora {amphora.id} of loadbalancer {amphora.loadbalancer_id} is rotated by a loadbalancer failover"
)
try:
conn.load_balancer.failover_load_balancer(amphora.loadbalancer_id)
sleep(10) # wait for the octavia API
for amphora in amphorae:
rotate = False

done.append(amphora.loadbalancer_id)
if amphora.loadbalancer_id in done:
continue

wait_for_amphora_boot(conn, amphora.loadbalancer_id)
wait_for_amphora_delete(conn, amphora.loadbalancer_id)
except openstack.exceptions.ConflictException:
logger.warning(
f"Conflict while rotating loadbalancer {amphora.loadbalancer_id}, skipping"
duration = datetime.now(timezone.utc) - dateutil_parser.parse(
amphora.created_at
)
if duration.total_seconds() > DEFAULT_ROTATION_AGE_SECONDS:
logger.info(f"Amphora {amphora.id} is older than 30 days")
rotate = True
elif force:
logger.info(f"Force rotation of Amphora {amphora.id}")
rotate = True
else:
continue

if rotate:
logger.info(
f"Amphora {amphora.id} of loadbalancer {amphora.loadbalancer_id} is rotated by a loadbalancer failover"
)
try:
conn.load_balancer.failover_load_balancer(
amphora.loadbalancer_id
)
sleep(10) # wait for the octavia API

done.append(amphora.loadbalancer_id)

wait_for_amphora_boot(conn, amphora.loadbalancer_id)
wait_for_amphora_delete(conn, amphora.loadbalancer_id)
except openstack.exceptions.ConflictException:
logger.warning(
f"Conflict while rotating loadbalancer {amphora.loadbalancer_id}, skipping"
)
finally:
cleanup_cloud_environment(temp_files, original_cwd)
Loading