changelog: add release notes for v0.20260808.0 - #2590
Merged
Conversation
Fixes RabbitMQ node address resolution: interface fact keys with dots (e.g. bond0.100) are preserved, resolution now goes through Ansible host-context templating and a controller-side action plugin, and console_interface is honoured as a fallback. Adds a SONiC config-generation E2E golden test and RabbitMQ integration tests wired into CI. Bumps sushy, next, eslint-config-next, gitpython, and huey. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Christian Berendt <berendt@osism.tech>
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="CHANGELOG.md" line_range="17" />
<code_context>
+- Add integration tests validating RabbitMQ node interface resolution against real Ansible, wired into CI (osism/python-osism#2577)
+
+### Fixed
+- Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)
+- Narrowed the secrets-file existence mock in rabbitmq tests so it no longer interferes with ansible's own file checks (osism/python-osism#2576)
+- Resolve RabbitMQ node internal_interface through Ansible host-context templating instead of a hand-written resolver, correctly handling all Jinja2 expression shapes (osism/python-osism#2578, osism/python-osism@9f78dc2)
</code_context>
<issue_to_address>
**issue (typo):** Correct "Rabbitmq" to "RabbitMQ" for consistent product naming.
This entry otherwise uses the correct "RabbitMQ" spelling, so please update this instance to match.
```suggestion
- RabbitMQ node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - Add integration tests validating RabbitMQ node interface resolution against real Ansible, wired into CI (osism/python-osism#2577) | ||
|
|
||
| ### Fixed | ||
| - Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575) |
There was a problem hiding this comment.
issue (typo): Correct "Rabbitmq" to "RabbitMQ" for consistent product naming.
This entry otherwise uses the correct "RabbitMQ" spelling, so please update this instance to match.
Suggested change
| - Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575) | |
| - RabbitMQ node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RabbitMQ node address resolution: interface fact keys with
dots (e.g. bond0.100) are preserved, resolution now goes through
Ansible host-context templating and a controller-side action
plugin, and console_interface is honoured as a fallback. Adds a
SONiC config-generation E2E golden test and RabbitMQ integration
tests wired into CI. Bumps sushy, next, eslint-config-next,
gitpython, and huey.
Generated with
generate-changelog-input.shusing claude-sonnet-5.