Skip to content

Release v0.1.9: address v0.1.8 review follow-ups - #34

Merged
sionsmith merged 1 commit into
mainfrom
codex/review-followups-v0.1.9
Sep 1, 2026
Merged

Release v0.1.9: address v0.1.8 review follow-ups#34
sionsmith merged 1 commit into
mainfrom
codex/review-followups-v0.1.9

Conversation

@sionsmith

@sionsmith sionsmith commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • prevent task responses with currency fields from being rendered as clients
  • correct generated duration examples in time command help
  • enforce the 4KB metadata limit after adding agent lifecycle fields
  • add regression coverage and bump the patch version to 0.1.9

Verification

  • cargo test --all-targets
  • cargo clippy --all-targets -- -D warnings
  • cargo audit
  • cargo run --bin gen-man

Summary by CodeRabbit

  • Bug Fixes
    • Task responses containing currency values now appear correctly in the task table, with billable status shown instead of being classified as clients.
    • Time command examples now use clear, human-readable duration formats such as 1h 30m.
    • Agent metadata is validated against the 4KB limit, providing an error when the payload is too large.
  • Release
    • Updated the application version to 0.1.9.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 96cd6944-652d-49b9-bb5a-27d45da5de4e

📥 Commits

Reviewing files that changed from the base of the PR and between 46a0eaa and ccad85a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • CHANGELOG.md
  • Cargo.toml
  • src/cli/time.rs
  • src/commands/time.rs
  • src/output/table.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

This release fixes task response rendering, validates final agent metadata against the 4KB limit, updates time command duration examples, and increments the package version to 0.1.9.

Changes

Time tracking fixes

Layer / File(s) Summary
Task table rendering
src/output/table.rs
Objects with billable_by_default are excluded from client detection. Tests verify that currency-bearing tasks use the task table with a “Billable” column.
Agent metadata size validation
src/commands/time.rs
Final agent metadata is serialized and rejected when it exceeds 4096 bytes. A unit test covers metadata that exceeds the limit after required fields are added.
Time examples and release metadata
src/cli/time.rs, CHANGELOG.md, Cargo.toml
Time command examples use 1h 30m. The changelog records the fixes, and the package version changes to 0.1.9.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ccad8

This release corrects CLI help examples, task-response rendering, and metadata-limit enforcement while adding regression coverage and updating the patch version; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the v0.1.9 release and accurately summarizes the review follow-ups addressed by the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/review-followups-v0.1.9

Comment @coderabbitai help to get the list of available commands.

@sionsmith
sionsmith merged commit 9b4c3bb into main Sep 1, 2026
10 checks passed
@sionsmith
sionsmith deleted the codex/review-followups-v0.1.9 branch September 1, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant