Skip to content

Conversation

@clalancette
Copy link
Collaborator

This PR does the bare minimum to implement 'use_sim_time' in rcljava. By 'bare minimum', I mean:

  • It revamps the Time class to be more like the rclcpp/rclpy equivalents.
  • It revamps the Clock class to be more like the rclcpp/rclpy equivalents.
  • It implements the TimeSource class, which is responsible for setting up the 'use_sim_time' parameter and subscribing to the '/clock' topic.
  • The current tests pass.
  • New tests for the revamped Time class were added.
  • No new tests for Clock or TimeSource were added.
  • There are still a few (relatively minor) TODO comments in the code.
  • I didn't test that this actually, you know, works.

Nevertheless, I think this is a good starting point to finish implementing 'use_sim_time'. The next steps here are to write tests, fix the TODOs, and then test that 'use_sim_time' actually works.

This replaces #5 .

@jacobperron @ivanpauno FYI.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@jacobperron jacobperron self-assigned this Aug 12, 2020
@jacobperron jacobperron changed the base branch from foxy-devel to feature/ros_time August 24, 2020 23:50
@jacobperron jacobperron merged commit 353561b into feature/ros_time Aug 24, 2020
@jacobperron jacobperron deleted the clalancette/revamp-time branch August 24, 2020 23:50
@jacobperron
Copy link

I've merged this into a feature branch. I'll continue iterating there, adding documentation and tests.

jacobperron pushed a commit that referenced this pull request Sep 18, 2020
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit that referenced this pull request Sep 18, 2020
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit that referenced this pull request Sep 18, 2020
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit that referenced this pull request Sep 18, 2020
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ivanpauno pushed a commit that referenced this pull request May 17, 2021
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
* Start revamping Time and Clock classes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Fixes from review.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in logging to the TimeSource class.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants