forked from ros2-java/ros2_java
-
Notifications
You must be signed in to change notification settings - Fork 9
Revamp Time #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Revamp Time #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
I've merged this into a feature branch. I'll continue iterating there, adding documentation and tests. |
jacobperron
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ivanpauno
pushed a commit
that referenced
this pull request
May 17, 2021
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
* Start revamping Time and Clock classes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in logging to the TimeSource class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the bare minimum to implement 'use_sim_time' in rcljava. By 'bare minimum', I mean:
Nevertheless, I think this is a good starting point to finish implementing 'use_sim_time'. The next steps here are to write tests, fix the TODOs, and then test that 'use_sim_time' actually works.
This replaces #5 .
@jacobperron @ivanpauno FYI.