[4.x] Fix Lambda permission SourceArn for the default event bus - #428
Merged
Conversation
Co-authored-by: james-at-tem <james.hallam@tem.energy>
SourceArn for the default event busSourceArn for the default event bus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
eventBridgeevent is configured with an expliciteventBus: default, the generatedAWS::Lambda::Permissionincluded a spuriousdefault/segment in itsSourceArncondition, producingrule/default/<rule-name>. AWS assigns rules on the default bus an ARN with no bus segment (rule/<rule-name>), so theArnLikecondition never matched and EventBridge was silently denied invoking the function on every invocation, with no error at deploy time. Events witheventBusomitted and named or custom buses were unaffected.The
SourceArnnow omits the bus segment for the default bus, mirroring the existing special case forEventBusNameon the rule resource. The default-bus tests now assert the fullSourceArnvalue instead of a single path segment, and coverage is added for a custom-named rule on the default bus. Fixes #426 and supersedes #427; thanks to @james-at-tem for the diagnosis and the original patch, credited as co-author.