[3.x] Fix Lambda permission SourceArn for default event bus - #429
Merged
Conversation
Co-authored-by: james-at-tem <james.hallam@tem.energy>
SourceArn for default event bus (3.x)SourceArn for default event bus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the same fix as #428 to the
3.xbranch, where the bug is also present (refs #426). When aneventBridgeevent is configured with an expliciteventBus: default, the generatedAWS::Lambda::Permissionincluded a spuriousdefault/segment in itsSourceArncondition, so theArnLikecondition never matched the real rule ARN (rule/<rule-name>) and EventBridge was silently denied invoking the function on every invocation. TheSourceArnnow omits the bus segment for the default bus, the default-bus tests assert the fullSourceArnvalue, and coverage is added for a custom-named rule on the default bus.The deprecated custom-resources path is not affected in the same silent way, since an explicit
eventBus: defaultthere already fails loudly at deploy time when the custom resource attempts to create the bus, so it is left untouched. Thanks to @james-at-tem for the diagnosis and the original patch, credited as co-author.