Skip to content

🌱 Fix PR verifier by replacing deprecated Docker action#4972

Open
justaugustus wants to merge 1 commit intoossf:mainfrom
justaugustus:fix/pr-verifier-action
Open

🌱 Fix PR verifier by replacing deprecated Docker action#4972
justaugustus wants to merge 1 commit intoossf:mainfrom
justaugustus:fix/pr-verifier-action

Conversation

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 21, 2026

What kind of change does this PR introduce?

Bug fix - Replaces deprecated Docker action that was causing all PR verifier checks to fail.

What is the current behavior?

The PR verifier check is failing for all pull requests with error: "Pull gcr.io/kubebuilder/pr-verifier:v0.4.3: failure"

The kubebuilder-release-tools Docker image became unavailable on March 18, 2025, as announced in kubernetes-sigs/kubebuilder-release-tools#60.

What is the new behavior (if this is a feature change)?

  • Tests for the changes have been added (for bug fixes/features)

The PR verifier now uses a shell script (scripts/verify-pr-title.sh) instead of the deprecated Docker action. The script performs the same PR title verification for required emoji prefixes and supports both emoji (🌱) and :emoji: (:seedling:) formats.

Tested locally with:

  • ✅ Valid emoji titles
  • ✅ Valid emoji code titles
  • ❌ Missing emoji (fails with helpful error)
  • ✅ Input validation (length limits, safe output handling)

Which issue(s) this PR fixes

N/A

Special notes for your reviewer

Supported emoji prefixes:

  • ⚠ Breaking change (:warning:)
  • ✨ Non-breaking feature (:sparkles:)
  • 🐛 Patch fix (:bug:)
  • 📖 Documentation (:book:)
  • 🚀 Release (:rocket:)
  • 🌱 Infra/Tests/Other (:seedling:)

The workflow now checks out the base branch to run the verification script.

Does this PR introduce a user-facing change?

NONE

@justaugustus justaugustus requested a review from a team as a code owner March 21, 2026 20:26
@justaugustus justaugustus requested review from jeffmendoza and raghavkaul and removed request for a team March 21, 2026 20:26
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 21, 2026
@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.67%. Comparing base (353ed60) to head (a3a9069).
⚠️ Report is 321 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4972      +/-   ##
==========================================
+ Coverage   66.80%   69.67%   +2.87%     
==========================================
  Files         230      251      +21     
  Lines       16602    15654     -948     
==========================================
- Hits        11091    10907     -184     
+ Misses       4808     3873     -935     
- Partials      703      874     +171     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justaugustus justaugustus force-pushed the fix/pr-verifier-action branch from ee151da to 6ae2bec Compare March 21, 2026 20:38
@dosubot dosubot bot removed the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 21, 2026
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 21, 2026
@justaugustus justaugustus changed the title 🐛 Fix PR verifier and harden against pull_request_target attacks 🌱 Fix PR title verifier Mar 21, 2026
@justaugustus justaugustus force-pushed the fix/pr-verifier-action branch from 6ae2bec to 04cdd2d Compare March 21, 2026 20:49
@justaugustus justaugustus changed the title 🌱 Fix PR title verifier 🐛 Fix PR verifier by replacing deprecated Docker action Mar 21, 2026
@justaugustus justaugustus requested review from AdamKorcz and spencerschrock and removed request for raghavkaul March 21, 2026 20:54
The kubebuilder-release-tools Docker image (gcr.io/kubebuilder/pr-verifier)
became unavailable on March 18, 2025, causing all PR verifier checks to fail.

This commit replaces the Docker action with a shell script that:
- Performs the same PR title verification for emoji prefixes
- Checks out base branch to run the verification script
- Validates title length (500 char max)
- Uses printf for safer output handling
- Maintains compatibility with both emoji and :emoji: formats

Supported emoji prefixes:
- ⚠ Breaking change
- ✨ Non-breaking feature
- 🐛 Patch fix
- 📖 Documentation
- 🚀 Release
- 🌱 Infra/Tests/Other

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Member Author

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spencerschrock @AdamKorcz — need a review, as this failure currently blocks all PRs.

@justaugustus justaugustus changed the title 🐛 Fix PR verifier by replacing deprecated Docker action 🌱 Fix PR verifier by replacing deprecated Docker action Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant