1.4.2 Release Candidate #3917
Merged
1.4.2 Release Candidate #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spears, throwing stars and small stones can still be equipped
using the it variable instead
more up to date format for "your last visit" message
Charm items are stackable so item:remove() ends up removing whole stack instead of just one out of the stack.
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
linter said it has nil value so It seems oke to declare the variable in the loop instead
EPuncker
requested changes
Jan 30, 2022
Fixing The Pale Count's looktype and corpse ID. It was previously using the looktype and corpse from a Gravedigger monster.
…d into another stack (otland#3918) A crash would occur when moving, for example, a stack of a single gold coin into another stack of gold coins. The crash would only occur when the last item of a stack was being moved, aka. the stack being destroyed.
…tland#3904) Fixes these scenarios: 1. Still being able to remove or add items from a container that is placed inside of a house tile, if the container was already open prior to being uninvited from the house 2. Being able to use useable items, like runes out of a house door or from a container placed in a house door, if it was already open prior to being uninvited from the house 3. houseTile always being nullptr inside of Container::queryRemove, since the cast was not done properly, and even after fixing the cast, it had wrong behaviour afterwards
With this modification you will be able to speak within the listening event without overflow problems when starting an infinite listening loop
Otherwise packages can fail to install due to stale index
Co-authored-by: Łukasz Zbiżek <Zbizu@users.noreply.github.com>
Follow-up to otland#3926 and otland#3197. Co-authored-by: Daniel Speichert <daniel@speichert.pl>
Fixes missing cryptopp during builds...for now
EPuncker
requested changes
Feb 24, 2022
EPuncker
approved these changes
Feb 24, 2022
|
I have been using this branch to develop on for more than a couple months now, for so long that I was confident enough, it was stable enough, for me to build on top of it, my own server. So I am just saying, this is a great candidate for 1.4.2 I had zero problems with it during its use. |
Codinablack
approved these changes
May 8, 2022
DSpeichert
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Cherry-picking bugfixes into 1.4.1 from master to make 1.4.2