AO3-5539 Fix hidden tags functionality for prompts/requests/external works - #5963
Open
techlingyi wants to merge 7 commits into
Open
AO3-5539 Fix hidden tags functionality for prompts/requests/external works#5963techlingyi wants to merge 7 commits into
techlingyi wants to merge 7 commits into
Conversation
techlingyi
commented
Aug 5, 2026
| @display_creation.tag_groups["ArchiveWarning"] | ||
| when 'freeforms' | ||
| @display_creation.freeforms | ||
| @display_creation.tag_groups["Freeform"] |
Contributor
Author
There was a problem hiding this comment.
It looks like Requests can't have their warnings/freeforms accessed with .archive_warnings or .freeforms, maybe because they're not Taggables? So I decided to just make all objects (except Series) access warnings/freeforms with tag_groups, since it also works for the other types of objects. Let me know if there's performance concerns with this, though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5539
Purpose
Makes it possible for users who have set their preferences to have warnings or additional tags hidden by default to click the "Show Warnings"/"Show Additional Tags" button to show warnings/additional tags on prompts (for prompt memes), requests (for gift exchanges), and external works.
Testing
Locate/create a prompt meme that allows prompts with warnings and additional tags; locate/create a prompt that has warnings and additional tags.
Locate/create a gift exchange that allows requests with warnings and additional tags; locate/create a request that has warnings and additional tags.
As the Jira issue says, log in as an admin, locate a bookmark of an external work, and use the "Edit External Work" option to add additional tags to it.
Then sign in as a different user from any of the above, go to the preferences page and set your preferences to hide warnings/additional tags by default, then go to the prompt, request, and external work bookmark above to check if the Show Warnings/Show Additional Tags buttons work.
Notes
I added a Cucumber test for showing hidden additional tags in prompts, but found it difficult to understand the infrastructure of the gift exchange and prompt meme step definitions, so couldn't figure out how to add Cucumber tests for anything else. It's fairly easy to test manually, but let me know if I should try again.
Credit
Ling-Yi (any pronouns)