Skip to content

AO3-5539 Fix hidden tags functionality for prompts/requests/external works - #5963

Open
techlingyi wants to merge 7 commits into
otwcode:masterfrom
techlingyi:AO3-5539-show-hidden-tags
Open

AO3-5539 Fix hidden tags functionality for prompts/requests/external works#5963
techlingyi wants to merge 7 commits into
otwcode:masterfrom
techlingyi:AO3-5539-show-hidden-tags

Conversation

@techlingyi

@techlingyi techlingyi commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-5539

Purpose

Makes it possible for users who have set their preferences to have warnings or additional tags hidden by default to click the "Show Warnings"/"Show Additional Tags" button to show warnings/additional tags on prompts (for prompt memes), requests (for gift exchanges), and external works.

Testing

Locate/create a prompt meme that allows prompts with warnings and additional tags; locate/create a prompt that has warnings and additional tags.

Locate/create a gift exchange that allows requests with warnings and additional tags; locate/create a request that has warnings and additional tags.

As the Jira issue says, log in as an admin, locate a bookmark of an external work, and use the "Edit External Work" option to add additional tags to it.

Then sign in as a different user from any of the above, go to the preferences page and set your preferences to hide warnings/additional tags by default, then go to the prompt, request, and external work bookmark above to check if the Show Warnings/Show Additional Tags buttons work.

Notes

I added a Cucumber test for showing hidden additional tags in prompts, but found it difficult to understand the infrastructure of the gift exchange and prompt meme step definitions, so couldn't figure out how to add Cucumber tests for anything else. It's fairly easy to test manually, but let me know if I should try again.

Credit

Ling-Yi (any pronouns)

@display_creation.tag_groups["ArchiveWarning"]
when 'freeforms'
@display_creation.freeforms
@display_creation.tag_groups["Freeform"]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Requests can't have their warnings/freeforms accessed with .archive_warnings or .freeforms, maybe because they're not Taggables? So I decided to just make all objects (except Series) access warnings/freeforms with tag_groups, since it also works for the other types of objects. Let me know if there's performance concerns with this, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant