AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed - #5966
Open
ScottVenkataraman wants to merge 3 commits into
Open
AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed#5966ScottVenkataraman wants to merge 3 commits into
ScottVenkataraman wants to merge 3 commits into
Conversation
Contributor
Author
|
I believe the test failures are unrelated to changes I made in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7565
Purpose
What does this PR do?
This PR makes the "fulfilled claims" button on the "claims" page appear selected when clicked.
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
You can follow the instructions from the Jira ticket for setup.
Once the "Fulfilled claims" button has been selected, add "&foo=bar" to the end of the url and press enter. If this is done without the changes added here, "Fulfilled Claims" appears unselected after the refresh. With these changes in place, the button remains selected after the refresh.
These instructions will be added to the Jira ticket
Credit
Scott Venkataraman he/him