build(deps): bump python-dotenv from 1.2.1 to 1.2.2 - #20
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [python-dotenv](https://github.com/theskumar/python-dotenv) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/theskumar/python-dotenv/releases) - [Changelog](https://github.com/theskumar/python-dotenv/blob/main/CHANGELOG.md) - [Commits](theskumar/python-dotenv@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: python-dotenv dependency-version: 1.2.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
ourway
added a commit
that referenced
this pull request
Jul 31, 2026
…re-2.x varchar to TEXT (issuedb #20, #21) Two consumer-reported defects from the 3.0.0 adoption round. No API change. Import-time secret warnings (issuedb #20, SPEC 0013) ---------------------------------------------------- `python -c "import auth"` printed the weak-AUTH_JWT_SECRET_KEY and weak-AUTH_AUDIT_PEPPER lines to stderr. auth/__init__.py imports auth.database, which builds the engine singleton at module scope, constructing Settings, whose validators warned. A client-only consumer signs no JWTs and writes no audit rows, so neither line is actionable — and both land in THAT consumer's boot logs, reading as their misconfiguration and training operators to ignore secret warnings. Reported independently by tokengate (thr-b7e8b0c2c7914d56b6f1) and runflow (thr-44794b4bbb6448c2bc01). The server path never needed them: create_app already calls verify_audit_pepper, which fails closed. Removed the two Settings validators; added config.warn_on_weak_secrets(), idempotent per process, called from create_app (server boot), create_tables and the Authorization wrapper (embedded). Fail-closed behavior at server boot is unchanged. varchar -> TEXT reconciliation (issuedb #21, SPEC 0014) ------------------------------------------------------- create_all(checkfirst=True) never ALTERs an existing table, so embedded databases created by pre-2.x versions keep narrow varchar widths where the current models declare Text. Encrypted values of longer identifiers overflow them, raising StringDataRightTruncation on write — highway hit this on auth_membership.user inside add_membership (thr-d99bb6c79b894ff69f16) and reconciled seven columns by hand. database._reconcile_text_columns() now widens exactly those columns on PostgreSQL, honoring AUTH_DATABASE_SCHEMA. Columns whose models declare a bounded String are untouched: audit_log.user is a fitted 64-char fingerprint, not an identifier, and widening it would erase a deliberate bound. The pass is idempotent (a matching database gets no ALTERs) and non-raising per column, so a runtime role without DDL rights logs and still starts. Verification ------------ Both defects reproduced first, then fixed, and asserted in both directions: - Subprocess probe, fresh interpreter per case, stderr captured separately, AUTH_* scrubbed, run from a temp cwd so the repo .env cannot mask it: bare import and Client construction are silent under WEAK secrets; create_tables, the Authorization wrapper and create_app DO warn under WEAK secrets; all are silent under STRONG secrets; create_app with a weak pepper and debug off still exits non-zero with "Refusing to start". - tests/postgres/test_text_column_reconciliation.py against real PostgreSQL 16: the narrow column genuinely raises DataError first (without that, the fix would prove nothing), reconciliation widens it to ("text", None), the same write then succeeds and round-trips intact, a second run issues no ALTERs, and audit_log.user stays ("character varying", 64). ruff, mypy, 214 unit tests, 15 postgres tests green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps python-dotenv from 1.2.1 to 1.2.2.
Release notes
Sourced from python-dotenv's releases.
Changelog
Sourced from python-dotenv's changelog.
Commits
36004e0Bump version: 1.2.1 → 1.2.2eb20252docs: update changelog for v1.2.2790c5c0Merge commit from fork43340daRemove the use ofshin tests (#612)09d7ceedocs: clarify override behavior and document FIFO support (#610)c8de288ci: improve workflow efficiency with best practices (#609)7bd9e3dAdd Windows testing to CI (#604)1baaf04Drop Python 3.9 support and update to PyPy 3.11 (#608)4a22cf8ci: enable testing on Python 3.14t (free-threaded) (#588)e2e8e77Fix license specifier (#597)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.