Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd not terminating when resource is locked forever #4037

Closed
nickvergessen opened this issue Oct 29, 2015 · 1 comment

Comments

@nickvergessen
Copy link
Contributor

commented Oct 29, 2015

Currently writing smashbox tests for locking.

  1. I created an artificial lock on a folder, which never expires.
  2. Create a new file in that folder locally
  3. Try to sync

Expected

The cmd terminates

Actual

It never terminates,
From the sync log:

<<#### Post-Reconcile end ####################################################  214
file2.dat - server replied: Locked" QVariant(int, 423)
[...]
Restarting Sync, because another sync is needed

This happens forever.

Now I can see that it may be useful, to have the client retrying.
However it would be nice (for testing purpose) to have something like a --max-sync-retries settings, which then terminates the client, with an error exit code.

cc @guruz

@guruz guruz self-assigned this Oct 29, 2015

@guruz guruz added this to the 2.1-next milestone Oct 29, 2015

@nickvergessen nickvergessen referenced this issue Oct 29, 2015
2 of 3 tasks complete

ogoffart added a commit that referenced this issue Oct 30, 2015

owncloudcmd: add --max-sync-retries #4037
And limit by default to 3 retries

@ogoffart ogoffart assigned ogoffart and unassigned guruz Oct 30, 2015

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2015

Tested and works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.