While coding #21557 it has been discovered (#22125) that smashbox has been broken on master with encryption enabled. There was effectively a case where users were not able to access their files.
This has been fixed by @PVince81 meanwhile with #22220. But considering that we only discovered this due to explicitly testing encryption ourselves we should certainly have smashbox executed on CI as well with encryption enabled. (not on the PRs probably but on the daily builds?)
cc @MorrisJobke @PVince81 As discussed.
cc @karlitschek @DeepDiver1975 Thoughts?
While coding #21557 it has been discovered (#22125) that smashbox has been broken on master with encryption enabled. There was effectively a case where users were not able to access their files.
This has been fixed by @PVince81 meanwhile with #22220. But considering that we only discovered this due to explicitly testing encryption ourselves we should certainly have smashbox executed on CI as well with encryption enabled. (not on the PRs probably but on the daily builds?)
cc @MorrisJobke @PVince81 As discussed.
cc @karlitschek @DeepDiver1975 Thoughts?