Fix part file partial cache logic in encryption code#22220
Merged
DeepDiver1975 merged 1 commit intomasterfrom Feb 9, 2016
Merged
Fix part file partial cache logic in encryption code#22220DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
This was referenced Feb 8, 2016
The encryption code uses partial cache entries for the part file (which are not stored in the database) but are useful for other parts of the code to retrieve the file size again. This means that in the fixed code $info was empty, so getData() could not be called. The fix makes sure to support both cases when the cache entry exists and doesn't.
LukasReschke
force-pushed
the
enc-fixfilesizelogicwithpartfile
branch
from
fc1b809 to
19980be
Compare
Member
|
Works here. Awesome, thanks a lot for taking care of this 🚀 👯 👍 |
Contributor
|
looks good 👍 |
Contributor
|
Running the most crucial smashbox atm just to be sure |
Contributor
|
shareFile passes again ✅ |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 9, 2016
Fix part file partial cache logic in encryption code
Contributor
|
Wonder why this happened only now. Don't remember that we changed anything here since 8.2.... Is this something we should consider backporting? @PVince81 @LukasReschke ? |
Contributor
Author
|
@schiesbn no, this was mistakenly changed by @icewind1991 in 9.0 as part of introducing ICacheEntry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encryption code uses partial cache entries for the part file (which
are not stored in the database) but are useful for other parts of the
code to retrieve the file size again.
This means that in the fixed code $info was empty, so getData() could
not be called.
The fix makes sure to support both cases when the cache entry exists and
doesn't.
Fixes #22125
Please review @LukasReschke @schiesbn @icewind1991 @nickvergessen