Skip to content

Minor difference in oc:trashbin-original-location PROPFIND response #39337

@phil-davis

Description

@phil-davis

Steps to reproduce

  1. have users Alice and Brian

  2. Alice creates a folder shared with sub-folder sub and in that is file shared_file.txt

  3. Alice shares folder shared with Brian

  4. Brian deletes shared/sub

  5. shared/sub/shared_file.txt appears in both the trashbin of Alice, and of Brian - good and expected

  6. Alice queries her trashbin:
    REQUEST: PROPFIND http://172.17.0.1:8080/remote.php/dav/trash-bin/Alice

  7. Brian queries his trashbin:
    REQUEST: PROPFIND http://172.17.0.1:8080/remote.php/dav/trash-bin/Brian

Expected behaviour

They both see the file shared_file.txt with the same value in oc:trashbin-original-location

Actual behaviour

Alice sees:
<oc:trashbin-original-location>/shared/sub/shared_file.txt</oc:trashbin-original-location>

Brian sees:
<oc:trashbin-original-location>shared/sub/shared_file.txt</oc:trashbin-original-location>

Alice has a leading / and Brian does not.

That may or may not break a client that wants to restore the file to its original location. But even if the clients are working OK, the difference is a bit odd.

I had to adjust the automated tests in #39336 to ignore this little difference, in order to get the overall tests to pass.

It might be better if the responses are consistent.

Server configuration

Current oC10 core master.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions