Skip to content

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 8, 2021

Description

Add test scenarios to demonstrate the behavior of the trashbin when files or folders are deleted from a share.

  • if the sharee deletes the file or folder then the deleted file(s) go in the trashbin of the sharee and sharer, but not the trashbin of anyone else who received the share (e.g. when the share was to a group)
  • if the sharer deletes the file or folder then the deleted file(s) go in the trashbin of the sharer only

The "rule" here is that the sharer always has access to the file(s) in their trashbin. The sharee that deletes something also has it in their trashbin (so that they can restore it if/when they realise that they accidentally deleted it)

I thought that we already had scenarios like this, but I couldn't find any - so I added them.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis force-pushed the trashbin-group-tests branch from f788e1b to 9bf8eb0 Compare October 11, 2021 16:21
@phil-davis phil-davis requested a review from SwikritiT October 11, 2021 16:21
@kiranparajuli589
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/32986/34/10
random failure due to services not ready, ci restarted

@phil-davis
Copy link
Contributor Author

I will rebase - this is a lot of commits behind master now.

@phil-davis phil-davis force-pushed the trashbin-group-tests branch from 9bf8eb0 to a7eaaac Compare October 19, 2021 10:26
@phil-davis phil-davis merged commit 7feefc6 into master Oct 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the trashbin-group-tests branch October 19, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants