Skip to content

use substituteInLineCodes() to check comment urls#34117

Merged
phil-davis merged 2 commits into
masterfrom
comment_url
Jan 11, 2019
Merged

use substituteInLineCodes() to check comment urls#34117
phil-davis merged 2 commits into
masterfrom
comment_url

Conversation

@individual-it

@individual-it individual-it commented Jan 11, 2019

Copy link
Copy Markdown
Member

Description

don't use magic a_comment_url check but substituteInLineCodes() like done in other places

first commit from #34115

Related Issue

Motivation and Context

clean code

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it requested review from dpakach, paurakhsharma, phil-davis and skshetry and removed request for phil-davis January 11, 2019 09:17
@individual-it individual-it self-assigned this Jan 11, 2019
@codecov

codecov Bot commented Jan 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34117   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18345    18345           
=========================================
  Files          1198     1198           
  Lines         69450    69450           
  Branches       1281     1281           
=========================================
  Hits          44982    44982           
  Misses        24095    24095           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18345 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7264a...c2ff246. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented Jan 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34117   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18345    18345           
=========================================
  Files          1198     1198           
  Lines         69450    69450           
  Branches       1281     1281           
=========================================
  Hits          44982    44982           
  Misses        24095    24095           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18345 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7264a...c2ff246. Read the comment docs.

@codecov

codecov Bot commented Jan 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34117   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18345    18345           
=========================================
  Files          1198     1198           
  Lines         69450    69450           
  Branches       1281     1281           
=========================================
  Hits          44982    44982           
  Misses        24095    24095           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18345 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7264a...c2ff246. Read the comment docs.

@phil-davis phil-davis merged commit 395c0a2 into master Jan 11, 2019
@delete-merged-branch delete-merged-branch Bot deleted the comment_url branch January 11, 2019 14:30
@phil-davis phil-davis mentioned this pull request Jan 12, 2019
Merged
@phil-davis

phil-davis commented Jan 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport stable10 #34123

phil-davis
phil-davis reviewed Jan 17, 2019
View reviewed changes
Comment thread tests/acceptance/features/bootstrap/WebDavPropertiesContext.php
require_once 'bootstrap.php';

/**
* Steps that relate to files_versions app

@phil-davis phil-davis Jan 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@individual-it is this a true comment about WebDavPropertiesContext?

@phil-davis phil-davis mentioned this pull request Feb 8, 2019
Merged
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@phil-davis phil-davis phil-davis approved these changes
@paurakhsharma paurakhsharma Awaiting requested review from paurakhsharma
@skshetry skshetry Awaiting requested review from skshetry
@dpakach dpakach Awaiting requested review from dpakach

Assignees

@individual-it individual-it

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

replace 'a_comment_url' magic with propper substitution

2 participants

@individual-it @phil-davis