Skip to content

fix snakeoil tests#35485

Merged
phil-davis merged 1 commit intomasterfrom
fixSnakeOilTests
Jun 11, 2019
Merged

fix snakeoil tests#35485
phil-davis merged 1 commit intomasterfrom
fixSnakeOilTests

Conversation

@individual-it
Copy link
Copy Markdown
Member

Description

these tests did not test anything, when running on an installation from git welcome.txt is there when disabling skeleton folder
when running on a QA tarball installation the tests did fail see owncloud/QA#623

issue with sharing with different cases usernames: #35484

Related Issue

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2019

Codecov Report

Merging #35485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35485   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65991b3...2108fbf. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2019

Codecov Report

Merging #35485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35485   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65991b3...2108fbf. Read the comment docs.

@phil-davis phil-davis merged commit d0a9837 into master Jun 11, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fixSnakeOilTests branch June 11, 2019 13:49
@phil-davis
Copy link
Copy Markdown
Contributor

Backport stable10 #35489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debug failing sharing API tests in user_ldap and files_primary_s3

2 participants