Skip to content

Acceptance test for renaming folders received from multiple users wit…#35664

Merged
individual-it merged 1 commit intoowncloud:masterfrom
bhawanaprasain:sharefolders
Jul 3, 2019
Merged

Acceptance test for renaming folders received from multiple users wit…#35664
individual-it merged 1 commit intoowncloud:masterfrom
bhawanaprasain:sharefolders

Conversation

@bhawanaprasain
Copy link
Copy Markdown
Contributor

Description

It includes test for renaming folders when auto-accept of shares is disabled and a user receives folders with matching name from multiple users .

Related Issue

#35414

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@phil-davis
Copy link
Copy Markdown
Contributor

@bhawanaprasain there were CI fails due to PHPunit problems last week.
Please rebase and then ping people to review when you are ready.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ec29c14). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35664   +/-   ##
=========================================
  Coverage          ?   65.67%           
  Complexity        ?    18777           
=========================================
  Files             ?     1222           
  Lines             ?    70935           
  Branches          ?     1289           
=========================================
  Hits              ?    46587           
  Misses            ?    23970           
  Partials          ?      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (?) 0 <ø> (?)
#phpunit 67.04% <ø> (?) 18777 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec29c14...1b32aa8. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2019

Codecov Report

Merging #35664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35664   +/-   ##
=========================================
  Coverage     65.81%   65.81%           
  Complexity    18818    18818           
=========================================
  Files          1228     1228           
  Lines         70982    70982           
  Branches       1289     1289           
=========================================
  Hits          46716    46716           
  Misses        23888    23888           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.19% <ø> (ø) 18818 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec29c14...1b32aa8. Read the comment docs.

Copy link
Copy Markdown
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the devious sequence that results in lots of (2) repeated on the end of the file name.
It is useful to have this in a test, then if someone cares to modify the code some day to make better use of other integers (3) (4) some day, they will have a test scenario to adjust :)

@phil-davis
Copy link
Copy Markdown
Contributor

There were some network errors in drone. I restarted the drone CI build just now.

@individual-it individual-it merged commit 0abe2df into owncloud:master Jul 3, 2019
@individual-it
Copy link
Copy Markdown
Member

@bhawanaprasain please make a backport to stable10 branch

@phil-davis
Copy link
Copy Markdown
Contributor

Backport stable10 #35754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants