Skip to content

Add webUI tests for share only with membership groups#35736

Merged
paurakhsharma merged 1 commit intomasterfrom
webUI-test-shareOnlyWithMembershipGroups
Jul 3, 2019
Merged

Add webUI tests for share only with membership groups#35736
paurakhsharma merged 1 commit intomasterfrom
webUI-test-shareOnlyWithMembershipGroups

Conversation

@paurakhsharma
Copy link
Copy Markdown
Member

@paurakhsharma paurakhsharma commented Jul 2, 2019

Description

Add webUI tests for share with only membership groups.

Related Issue

#35673

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma requested review from dpakach and skshetry July 2, 2019 09:32
@paurakhsharma paurakhsharma self-assigned this Jul 2, 2019
dpakach
dpakach reviewed Jul 2, 2019
View reviewed changes
Comment thread tests/acceptance/features/lib/AdminSharingSettingsPage.php
dpakach
dpakach reviewed Jul 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

phil-davis
phil-davis reviewed Jul 2, 2019
View reviewed changes
Comment thread tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature Outdated
Comment thread tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature Outdated
@paurakhsharma paurakhsharma requested a review from phil-davis July 2, 2019 11:28
@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from 1f475bb to e515994 Compare July 2, 2019 11:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f60d4aa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35736   +/-   ##
=========================================
  Coverage          ?   49.09%           
=========================================
  Files             ?      109           
  Lines             ?    10535           
  Branches          ?     1289           
=========================================
  Hits              ?     5172           
  Misses            ?     4985           
  Partials          ?      378
Flag Coverage Δ
#javascript 53.7% <ø> (?)
#phpunit 38.78% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60d4aa...e515994. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2019 •
edited
Loading

Codecov Report

Merging #35736 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35736   +/-   ##
=========================================
  Coverage     65.81%   65.81%           
  Complexity    18818    18818           
=========================================
  Files          1228     1228           
  Lines         70982    70982           
  Branches       1289     1289           
=========================================
  Hits          46716    46716           
  Misses        23888    23888           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.19% <ø> (ø) 18818 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8c3d7...82b2a2f. Read the comment docs.

@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from e515994 to e3fbf8b Compare July 3, 2019 05:47
@paurakhsharma paurakhsharma force-pushed the webUI-test-shareOnlyWithMembershipGroups branch from e3fbf8b to 82b2a2f Compare July 3, 2019 07:19
@paurakhsharma paurakhsharma merged commit bb93190 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch Bot deleted the webUI-test-shareOnlyWithMembershipGroups branch July 3, 2019 09:22
@paurakhsharma paurakhsharma mentioned this pull request Jul 3, 2019
Merged
@paurakhsharma
Copy link
Copy Markdown
Member Author

paurakhsharma commented Jul 3, 2019

Backport on: #35753

@phil-davis phil-davis mentioned this pull request Jul 8, 2019
Open
4 tasks
@PVince81 PVince81 mentioned this pull request Jul 8, 2019
Open
22 tasks
@paurakhsharma paurakhsharma mentioned this pull request Jul 8, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@skshetry skshetry Awaiting requested review from skshetry

+1 more reviewer

@dpakach dpakach dpakach left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@paurakhsharma paurakhsharma

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paurakhsharma @phil-davis @dpakach