Create 36505#36516
Closed
pako81 wants to merge 1 commit into
Closed
Conversation
micbar
suggested changes
Dec 3, 2019
Contributor
micbar
left a comment
micbar
left a comment
There was a problem hiding this comment.
Thx.
- Actually this should go to the original PR
- The first line should not exceed 80 chars
- The first should be written in present tense
- The summary should be written in past tense, like you already did.
Author
|
@micbar ops, sorry for the mistake. I have now done this in the original PR and also made the suggested changes. Closing this? |
Codecov Report
@@ Coverage Diff @@
## master #36516 +/- ##
=========================================
Coverage 64.68% 64.68%
Complexity 19024 19024
=========================================
Files 1268 1268
Lines 74369 74369
Branches 1311 1311
=========================================
Hits 48106 48106
Misses 25877 25877
Partials 386 386
Continue to review full report at Codecov.
|
Contributor
|
closing favor of #36505. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created changelog item for #36505