[Tests-Only] Support skipOnFedOcV tags in acceptance tests#37837
Merged
Conversation
individual-it
approved these changes
Aug 24, 2020
This was referenced Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes a fix is known to be not compatible with older federated server versions. In that case we need to be able to skip a scenario when running against an older federated server.
When running tests with a federated server, tags are automatically added for the federated server under test, in the form:
@skipOnFedOcV10.5@skipOnFedOcV10.5.0So these tags can be added to scenarios as necessary.
This has been triggered by PR #37835 - we have had cases like this in the past, and it would be nice to have a flexible solution.
How Has This Been Tested?
CI
Types of changes
Checklist: