Skip to content

[full-ci] [tests-only] Adjust tests for infinite depth changes#40021

Closed
phil-davis wants to merge 9 commits into
masterfrom
e-5154-inf-depth-tests-2
Closed

[full-ci] [tests-only] Adjust tests for infinite depth changes#40021
phil-davis wants to merge 9 commits into
masterfrom
e-5154-inf-depth-tests-2

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

On top of PR #40016

WIP - need to sort out acceptance tests that use the new default (infinite depth off), and with it on.

@phil-davis
Copy link
Copy Markdown
Contributor Author

Now we have only trashbin test scenarios left to get passing.
https://drone.owncloud.com/owncloud/core/35488/83/13

apiTrashbin/trashbinDelete.feature:106
apiTrashbin/trashbinDelete.feature:122
apiTrashbin/trashbinFilesFolders.feature:289
apiTrashbin/trashbinFilesFolders.feature:290
apiTrashbin/trashbinSharingToRoot.feature:102
apiTrashbin/trashbinSharingToRoot.feature:103
apiTrashbin/trashbinSharingToRoot.feature:124
apiTrashbin/trashbinSharingToRoot.feature:125
apiTrashbin/trashbinSharingToRoot.feature:147
apiTrashbin/trashbinSharingToRoot.feature:148
apiTrashbin/trashbinSharingToShares.feature:160
apiTrashbin/trashbinSharingToShares.feature:161
apiTrashbin/trashbinSkip.feature:142
apiTrashbin/trashbinSkip.feature:143
apiTrashbin/trashbinSkip.feature:193
apiTrashbin/trashbinSkip.feature:194
apiTrashbin/trashbinSkip.feature:286
apiTrashbin/trashbinSkip.feature:287

https://drone.owncloud.com/owncloud/core/35488/84/13

runsh: Total unexpected failed scenarios throughout the test run:
apiTrashbinRestore/trashbinRestore.feature:309
apiTrashbinRestore/trashbinRestore.feature:310
apiTrashbinRestore/trashbinRestore.feature:329
apiTrashbinRestore/trashbinRestore.feature:330
apiTrashbinRestore/trashbinRestore.feature:459
apiTrashbinRestore/trashbinRestore.feature:460
apiTrashbinRestore/trashbinRestore.feature:478
apiTrashbinRestore/trashbinRestore.feature:479
apiTrashbinRestore/trashbinRestore.feature:502
apiTrashbinRestore/trashbinRestore.feature:503
apiTrashbinRestore/trashbinRestore.feature:521
apiTrashbinRestore/trashbinRestore.feature:522

Existing test code does a trashbin PROPFIND with depth infinity and gets a response that contains the whole trashbin content in a single request. It then loops through all that data and examines oc:trashbin-original-location to find the entry that matches. That lets the test code find a specified resource in the trashbin in a single pass.

But now the "infinity" PROPFIND is not available. When the code is looking for a resource that used to be at the root level, there is no pfroblem - a depth 1 PROPFIND has the resource mentioned. But when the resource is down in sub-folders:

    But as "Alice" the file with original path "/FOLDER/parent.txt" should exist in the trashbin

the test code will have to find the id of /FOLDER and then do a PROPFIND on that id:

http://172.17.0.1:8080/remote.php/dav/trash-bin/admin/2147496709

We can't just PROPFIND to something like

http://172.17.0.1:8080/remote.php/dav/trash-bin/admin/FOLDER

I will code that tomorrow.

Other clients will also have to use this kind of logic to traverse down into the trashbin. The traditional webUI must do that OK, because all the webUI trashbin acceptance tests are passing. If will be good to also check that other clients (desktop, iOS, Android) can traverse the trashbin OK when depth infinity PROPFIND is not available.

@phil-davis phil-davis force-pushed the e-5154-inf-depth-tests-2 branch 3 times, most recently from 81e5d8a to 10a9de5 Compare April 28, 2022 11:55
@phil-davis phil-davis force-pushed the e-5154-inf-depth-tests-2 branch from 9b5b481 to f118685 Compare April 29, 2022 10:43
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@phil-davis
Copy link
Copy Markdown
Contributor Author

Passes - great. I have cherry-picked this into PR #40016

@phil-davis phil-davis closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants