[tests-only] test: return the LDAP port number as a string#41500
Merged
phil-davis merged 1 commit intomasterfrom Mar 13, 2026
Merged
[tests-only] test: return the LDAP port number as a string#41500phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
The number is substituted into Behat Gherkin step text, as a textual number. We need to be able to use str_replace() with the LDAP port "number" as the replacement string. In PHP8 the parameters passed to str_replace() must be strings. In user_ldap acceptance tests we are getting: When the administrator sets the LDAP config "LDAPTestId" key "ldapPort" to "%ldap_port%" using the occ command # UserLdapGeneralContext::ldapConfigHasKeySetTo() Type error: str_replace(): Argument #2 ($replace) must be of type array|string, int given (Behat\Testwork\Call\Exception\FatalThrowableError) This change should fix the problem.
phil-davis
requested review from
DeepDiver1975,
individual-it,
jvillafanez and
saw-jan
individual-it
approved these changes
Mar 13, 2026
BWTECH-github
added a commit
to BWTECH-github/owncloud.online
that referenced
this pull request
Mar 16, 2026
…ibility - getLdapPort():int → getLdapPortAsString():string - Fixes str_replace() type error in LDAP acceptance tests - Based on owncloud/core#41500
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number is substituted into Behat Gherkin step text, as a textual number. We need to be able to use str_replace() with the LDAP port "number" as the replacement string.
In PHP8 the parameters passed to str_replace() must be strings.
In user_ldap acceptance tests we are getting:
When the administrator sets the LDAP config "LDAPTestId" key "ldapPort" to "%ldap_port%" using the occ command # UserLdapGeneralContext::ldapConfigHasKeySetTo()
Type error: str_replace(): Argument 2 ($replace) must be of type array|string, int given (Behat\Testwork\Call\Exception\FatalThrowableError)
This change should fix the problem.