feat: PHP 8.4 compatibility and owncloud.online design#41503
feat: PHP 8.4 compatibility and owncloud.online design#41503BWTECH-github wants to merge 3 commits intoowncloud:masterfrom
Conversation
- Updated PHP codebase for full PHP 8.4 compatibility - Resolved deprecation warnings and breaking changes - Integrated owncloud.online custom design theme - Updated README with owncloud.online branding
…ibility - getLdapPort():int → getLdapPortAsString():string - Fixes str_replace() type error in LDAP acceptance tests - Based on owncloud#41500
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Just a few things that I quickly noticed.
This will need a lot of detailed looking at the diffs to sort it out. I suppose "stuff happened" in the merge conflict resolution...
| @@ -348,6 +348,7 @@ Feature: edit users | |||
| When user "subadmin" changes the display name of user "Alice" to "Alice Wonderland" using the provisioning API | |||
| Then the OCS status code should be "100" | |||
| And the HTTP status code should be "200" | |||
| | displayname | Alice Wonderland | | |||
There was a problem hiding this comment.
What is this trying to achieve?
There was a problem hiding this comment.
That was an accidental artifact from our merge process — the DataTable line doesn't belong there. We'll remove it.
| @@ -334,6 +334,7 @@ Feature: edit users | |||
| And user "subadmin" changes the display name of user "Alice" to "Alice Wonderland" using the provisioning API | |||
| Then the OCS status code should be "200" | |||
| And the HTTP status code should be "200" | |||
| | displayname | Alice Wonderland | | |||
There was a problem hiding this comment.
What is this trying to achieve?
There was a problem hiding this comment.
That was an accidental artifact from our merge process — the DataTable line doesn't belong there. We'll remove it.
| DEFAULT_PHP_VERSION = "8.3" | ||
| DEFAULT_PHP_VERSION = "7.4" |
There was a problem hiding this comment.
Why changing back to PHP 7.4?
There was a problem hiding this comment.
Good catch, thanks! That was an unintended regression — it should be 8.4 instead of 7.4. We'll fix this.
| "symfony/console": "^7.3", | ||
| "symfony/event-dispatcher": "^7.3", | ||
| "symfony/process": "^7.3", | ||
| "symfony/routing": "^7.3", | ||
| "symfony/translation": "^7.3", | ||
| "symfony/mailer": "^7.3" |
There was a problem hiding this comment.
Why going backwards with the minor version requirement?
There was a problem hiding this comment.
You're right - no reason to go backwards here. Symfony 7.4 is the current LTS with support until 2028, while 7.3 is already unmaintained. We'll bump it back to ^7.4.
| @@ -1,14 +1,14 @@ | |||
| # ownCloud Core | |||
| # ownCloud.online | |||
There was a problem hiding this comment.
I don't think that the README chnages are wanted.
|
Thank you @BWTECH-github For the time being we are aiming for php8.3 only. Once we have a stable code base we can think about adding support for 8.4 and even 8.5 |
|
Commits are mentioning forking ownCloud/core. I assume this PR is targeting the wrong repo. |
4 participants
Summary
This PR brings full PHP 8.4 compatibility to ownCloud Core along with a custom design theme for owncloud.online.
Changes
PHP 8.4 Compatibility
composer.jsonto require PHP >= 8.4str_replace()type errors (e.g. LDAP port as string)explode()and other string functions receivingnullinstead ofstringDeprecated: Creation of dynamic propertywarningsArrayAccessoffset type compatibilityowncloud.online Design
core/img/design-preview.pngLDAP Test Fix
getLdapPort():int→getLdapPortAsString():stringstr_replace()type error in LDAP acceptance tests (related to [tests-only] test: return the LDAP port number as a string #41500)Testing
Stats
Maintained by BW.Tech