Skip to content

fix(settings): load renamed Jcrop 2.0 assets for avatar cropper #41724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phil-davis merged 2 commits into from
Jul 24, 2026
+16 −2
Merged

fix(settings): load renamed Jcrop 2.0 assets for avatar cropper #41724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01f73b
fix(settings): load renamed Jcrop 2.0 assets for avatar cropper
DeepDiver1975 Jul 24, 2026
afe1871
chore: adjust changelog links for avatar cropper fix
phil-davis Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions changelog/unreleased/avatar-cropper-jcrop-path
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Bugfix: Fix avatar cropper broken by Jcrop 2.0 file rename

Uploading a non-square profile picture opened a cropper that immediately failed
with "$cropperImage.Jcrop is not a function". Bumping the Jcrop dependency from
0.9.12 to 2.0.4 renamed its distribution files from js/jquery.Jcrop.js and
css/jquery.Jcrop.css to js/Jcrop.js and css/Jcrop.css, but the personal profile
template still referenced the old paths. The script therefore failed to load,
the plugin never registered on jQuery, and the cropper could not be shown. The
template now loads the renamed Jcrop assets.

Original Jcrop PR: https://github.com/owncloud/core/pull/38666

https://github.com/owncloud/core/issues/41723
https://github.com/owncloud/core/pull/41724
4 changes: 2 additions & 2 deletions settings/templates/panels/personal/profile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
vendor_script('strengthify/jquery.strengthify');
vendor_style('strengthify/strengthify');
if ($_['enableAvatars']) {
vendor_script('jcrop/js/jquery.Jcrop');
vendor_style('jcrop/css/jquery.Jcrop');
vendor_script('jcrop/js/Jcrop');
vendor_style('jcrop/css/Jcrop');
}
?>
<?php if ($_['enableAvatars']): ?>
Expand Down