Also quote oldColumnName for db migration

[bartv2]

see #7415

[PVince81]

It doesn't seem to work, I still get the same error. Already tested this two times.
Are you sure it's the right place ?
The error still shows the first column as unquoted:

An exception occurred while executing 'ALTER TABLE `oc_privatedata` CHANGE user `user` VARCHAR(255) DEFAULT '' NOT NULL, CHANGE app `app` VARCHAR(255) DEFAULT '' NOT NULL, CHANGE key `key` VARCHAR(255) DEFAULT '' NOT NULL, CHANGE value `value` VARCHAR(255) DEFAULT '' NOT NULL': SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'key `key` VARCHAR(255) DEFAULT '' NOT NULL, CHANGE value `value` VARCHAR(255) DE' at line 1

[PVince81]

{"app":"PHP","message":"Undefined property: Doctrine\\DBAL\\Schema\\TableDiff::$oldColumnName at \/srv\/www\/htdocs\/owncloud2\/lib\/private\/db\/mdb2schemamanager.php#85","level":3,"time":"2014-02-26T15:06:19+00:00"}

[PVince81]

Looks like you need to iterate over $tableDiff->changedColumns (saw it in the debugger) and quote their names

[bartv2]

@PVince81 can you do the change?

[PVince81]

Ok, I'll take over this and let you review it

[PVince81]

New PR: #7430 (had trouble force pushing)

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3371/

[PVince81]

@owncloud-bot retest this please

[PVince81]

@owncloud-bot ah no forget it forget it!

[scrutinizer-notifier]

The inspection completed: No new issues