[stable6] Also quote old column name during DB migration

[PVince81]

This fixes alter table commands that didn't quote the old column name

Please review @bartv2 @DeepDiver1975 @bantu

Fixes #7415

I've tested this twice.

[PVince81]

and @karlitschek

[PVince81]

@felixboehm can you test migration with this PR with MSSQL ? With a bit of luck it can solve its migration issue as well.

[PVince81]

• MySQL
• PostgreSQL
• SQLite
• MSSQL: FAIL, unrelated to this change
• Oracle: FAIL, unrelated to this change (Upgrade error from stable5 to stable6 with Oracle #7435)

[DeepDiver1975]

can you test migration with this PR with MSSQL ? With a bit of luck it can solve its migration issue as well.

I'll test this on mssql ....

[karlitschek]

Thanks guys

[DeepDiver1975]

I'll test this on mssql ....

This will not help with the MSSQL issue reported by @felixboehm - I'm working on a fix for this

[PVince81]

Just tested on Oracle, and Oracle has a different error which happens regardless of this PR.
I'll raise a separate ticket for the Oracle issue.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3372/

[PVince81]

Here is the Oracle issue: #7435

I'll tick MSSQL and Oracle since we tested them

[PVince81]

@bartv2 @DeepDiver1975 @karlitschek @bantu this important fix still needs to be reviewed.
Thanks.

[PVince81]

or @icewind1991

[DeepDiver1975]

@PVince81 I assume we can write a unit test for this.
All we need is a table with a columns key where we change the size - this should trigger the exact same error message from my understanding.

Let's see if I can build something ....

[DeepDiver1975]

#7439 is failing - I'll merge the unit tests now in here ...

[scrutinizer-notifier]

A new inspection was created.

[PVince81]

Nice PR juggling 😉
Curious to see the result.

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3386/

[DeepDiver1975]

Failing unit tests are unrelated

[DeepDiver1975]

👍

[PVince81]

This needs another reviewer, required for 6.0.2 RC2 later today, thanks

[DeepDiver1975]

@butonic @icewind1991 @bantu @bartv2 review maybe?

[butonic]

Testing now

[butonic]

👍 tests worked locally. jenkins failed because of etag asserts

[PVince81]

Will prepare the forward port to master on the other PR

[PVince81]

Forward port is here: #7439