-
Notifications
You must be signed in to change notification settings - Fork 2.1k
icons: automatically show delete hover instead of using explicit class #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new inspection was created. |
|
As I suggested it ;) 👍 |
|
But I'm not sure we should backport the icon styles. |
|
Nice 👍 |
|
Don't backport too quickly, we are still in RC phase and only critical fixes should be backported. |
|
@PVince81 that icons.css has been introduced in master for oc7. The side effect is minimal in the current phase |
|
It's just a matter of principle. If people see that many non-critical backports are allowed through they might be tempted to also backport as much as possible and risk destabilizing the build. |
Totally agreed - read my comment as background information |
|
Ok, so it is kind of critical for app developers then and can't wait for OC 6.0.3 |
|
🚀 Test Passed. 🚀 |
icons: automatically show delete hover instead of using explicit class
Fix the need for app developers to manually add the hover state.
Please review @tanghus @owncloud/designers
Also, we should probably backport all the icons.css changes. This, and #7382 (by @jbtbnl), and https://github.com/owncloud/core/commits/master/core/css/icons.css Ok @karlitschek @DeepDiver1975?