Skip to content

Conversation

@jancborchardt
Copy link
Member

Fix the need for app developers to manually add the hover state.

Please review @tanghus @owncloud/designers

Also, we should probably backport all the icons.css changes. This, and #7382 (by @jbtbnl), and https://github.com/owncloud/core/commits/master/core/css/icons.css Ok @karlitschek @DeepDiver1975?

@scrutinizer-notifier
Copy link

A new inspection was created.

@tanghus
Copy link
Contributor

tanghus commented Feb 27, 2014

As I suggested it ;) 👍

@tanghus
Copy link
Contributor

tanghus commented Feb 27, 2014

But I'm not sure we should backport the icon styles.

@MorrisJobke
Copy link
Contributor

Nice 👍

@PVince81
Copy link
Contributor

Don't backport too quickly, we are still in RC phase and only critical fixes should be backported.
But after the release backporting might be ok, for 6.0.3

@DeepDiver1975
Copy link
Member

@PVince81 that icons.css has been introduced in master for oc7.
We decided to backport is for optional use by apps which want to be compatible with oc6 and oc7 using the same code base - e.g. our documents app is doing so.

The side effect is minimal in the current phase

@PVince81
Copy link
Contributor

It's just a matter of principle. If people see that many non-critical backports are allowed through they might be tempted to also backport as much as possible and risk destabilizing the build.
Yes, it isn't the case for the icons.css one but might be for others.

@DeepDiver1975
Copy link
Member

It's just a matter of principle. If people see that many non-critical backports are allowed through they might be tempted to also backport as much as possible and risk destabilizing the build.

Totally agreed - read my comment as background information

@PVince81
Copy link
Contributor

Ok, so it is kind of critical for app developers then and can't wait for OC 6.0.3

@ghost
Copy link

ghost commented Feb 27, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3398/

MorrisJobke added a commit that referenced this pull request Feb 27, 2014
icons: automatically show delete hover instead of using explicit class
@MorrisJobke MorrisJobke merged commit 7af846e into master Feb 27, 2014
@MorrisJobke MorrisJobke deleted the icon-delete-hover branch February 27, 2014 13:44
@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants