stable6 icons.css backports #7472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the icon specific class is needed
Contributor
|
Great :) |
|
🚀 Test Passed. 🚀 |
|
The inspection completed: No new issues |
Member
Author
|
More reviews and thumbs up please. We should have this backported. @karlitschek @DeepDiver1975 @owncloud/designers |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
jancborchardt
added a commit
that referenced
this pull request
Feb 28, 2014
stable6 icons.css backports
Member
Author
|
Thanks! :) |
Contributor
|
hmm. ok. Next time please wait for me and explain which real life issue something like this fixes. Thanks |
Contributor
Member
Author
|
@karlitschek sorry! :) Since both Björn and Vince gave their thumbs up, I assumed you were ok with it and said to them to check it. Forgot you aren’t in the office today. |
Contributor
|
O.K. Please wait for me next time. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in #7452
This is an improvement to the icons.css file we introduced. It’s a clean backport but nevertheless I’m doing it as pull request so everyone can check cc @karlitschek @DeepDiver1975 @owncloud/designers @tanghus
The reason this should be backported: icons.css is an addition and does not break existing stuff and it was backported to enable app devs to use the same code in ownCloud 6 and master. Without these backports, that use is moot.
Please review.