add hover/focus states for star icons to hint at action #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new inspection was created. |
jancborchardt
referenced
this pull request
Mar 5, 2014
Member
Author
|
@tanghus by the way, anything else missing from that file? Then we should do it in this pull request. |
Contributor
|
👍 |
|
🚀 Test Passed. 🚀 |
Contributor
|
@jancborchardt agreed for the backport. It is better to discuss this in a comment after the merge to master. |
Member
|
👍 |
raghunayyar
pushed a commit
that referenced
this pull request
Mar 5, 2014
add hover/focus states for star icons to hint at action
Member
Author
|
Ok @karlitschek, will do in future pull requests. Backported as 6b45835 |
Contributor
@jancborchardt Not from the top of my head |
Member
Author
|
@tanghus ok. Thanks again for spotting these things in icons.css :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @tanghus in 25e9b7a#commitcomment-5563957
Please review @owncloud/designers
This one should be backported as well, just like #7472 – ok @karlitschek?