Backport fix: [OCISDEV-879] disalow the 3xx redirectst for the ocm http client - #643
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kobergj
approved these changes
Jun 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR backports a security hardening fix for OCM by (1) preventing the OCM WebDAV HTTP client from following 3xx redirects and (2) validating that inbound OCM protocol URIs use an allowed scheme (https by default, optional http via config) before downstream code consumes them.
Changes:
- Add a custom
RoundTripperto tag outbound WebDAV requests so gowebdav inhibits following redirects. - Add URI scheme/host validation for OCM share-create protocols, with a new
allow_httpconfig toggle. - Add unit tests for URI scheme validation and a changelog entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/ocm/storage/received/ocm.go | Wrap WebDAV transport to inhibit redirects; introduce a custom HTTP transport configuration. |
| internal/http/services/ocmd/shares.go | Validate URI schemes for protocol fields during CreateShare request parsing; wire allow_http into handler. |
| internal/http/services/ocmd/scheme_test.go | Add unit tests for validateURIScheme. |
| internal/http/services/ocmd/protocols.go | Implement validateURIScheme helper for https/http-only URI validation. |
| internal/http/services/ocmd/ocm.go | Add allow_http configuration field. |
| changelog/unreleased/fix-ocm-validation.md | Document the fix in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mklos-kw
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix: [OCISDEV-879] disalow the 3xx redirectst for the ocm http client