Allow plus in LDAP usernames

[phil-davis]

core PR owncloud/core#36613 proposes allowing + in usernames.

If that PR is accepted, then we should/could also allow + in usernames coming from LDAP.

This PR implements that, and adds unit tests to check the LDAP sanitizeUsername() method. (There were not any tests for that yet)

• set minimum core version to 10.4 (we only want to allow sync of LDAP usernames containing + if core also supports usernames containing +)

IMO this should only be merged and released after core 10.4 has been released.

[phil-davis]

@pako81 this would also be needed if we start allowing + in usernames/UIDs

[codecov]

Codecov Report

Merging #490 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #490      +/-   ##
============================================
+ Coverage     36.75%   36.91%   +0.16%     
  Complexity     1305     1305              
============================================
  Files            31       31              
  Lines          3700     3700              
============================================
+ Hits           1360     1366       +6     
+ Misses         2340     2334       -6     

Impacted Files	Coverage Δ	Complexity Δ
lib/Access.php	7.67% <0.00%> (+0.80%)	281.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195e509...b1677a7. Read the comment docs.

[pako81]

@phil-davis makes sense 👍

[phil-davis]

CI here is "stuck" - with core min version 10.4 we cannot have test pipelines against latest.
But there is no rush - we can run CI again when core 10.4 is latest.

[mmattel]

@phil-davis has there anything changed that allows a progress 😅

[phil-davis]

I rebased to catch up with current user_ldap.

There is no point releasing this anyway, until core 10.4 is out. So we can easily merge this the day that 10.4 community release happens and release user_ldap soon after.

[phil-davis]

@micbar @HanaGemela I adjusted CI so that it does not test against core latest (which is 10.3.2)

CI should pass. We could merge this PR and start the process for a user_ldap release to go with core 10.4.0

[micbar]

@phil-davis Does it really have a strickt dependency? what would happen, if I use the current version with 10.4.0?

[phil-davis]

If your LDAP does not actually have any usernames containing + then yes, it should still work on a core 10.2 or 10.3 system.

Do you want to try and keep the new version of user_ldap installable on 10.2 and 10.3?

[phil-davis]

Note: if we wait until core 10.4.0 becomes the "latest" community tarball, then I can remove the last commit from this PR.

[phil-davis]

Note: if we wait until core 10.4.0 becomes the "latest" community tarball, then I can remove the last commit from this PR.

10.4.0 is now "latest". I reverted the 3rd commit. Let's see what happens to CI.

[mmattel]

Green, green 😄

[phil-davis]

@micbar please get a review of this.