Skip to content

Conversation

@dschmidt
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

@LukasHirt
Copy link
Collaborator

I tried to run this locally and I see the importer but trying to import e.g. from google drive quickly shows up an "authorisation blocked" error and then quickly closes the google auth page. I guess this is due to some missing config on my side and not an issue with the update?

@LukasHirt
Copy link
Collaborator

LukasHirt commented Dec 23, 2024

Public link also does not work... the response does not include anything else than Bad request. I used a public link without password with URL https://host.docker.internal:9200/s/OrcBNpNQTGyLeEO.

image

This request failed:

curl 'https://host.docker.internal:9200/companion/webdavPublicLink/list/?publicLinkURL=https%3A%2F%2Fhost.docker.internal%3A9200%2Fs%2FOrcBNpNQTGyLeEO' \
  -H 'accept: application/json' \
  -H 'accept-language: cs,en;q=0.9' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'cookie: connect.sid=s%3A8MoziaZSmKu1ifq6dnR8h3CAX1SyFqHY.Dr1hnidwA%2B9fk2PBBy1J%2BnZc8YkEK3gsDlDlEH4RGiM' \
  -H 'pragma: no-cache' \
  -H 'priority: u=1, i' \
  -H 'referer: https://host.docker.internal:9200/files/spaces/personal/admin?fileId=d57c6805-9324-4bbf-adaa-6dadd248b81f%243b06d595-3d2c-40aa-9fee-447ee4f8c3db%213b06d595-3d2c-40aa-9fee-447ee4f8c3db&sort-by=name&sort-dir=asc&items-per-page=100&files-spaces-generic-view-mode=resource-table&tiles-size=1' \
  -H 'sec-ch-ua: "Google Chrome";v="131", "Chromium";v="131", "Not_A Brand";v="24"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36' \
  --insecure

@dschmidt
Copy link
Member Author

Google will only work, when it's properly configured yes.

The request you're seeing looks fishy: webdavPublicLink in the url should be webdav now afaict.
Also it won't fully work without a patched companion (or ocis).

@LukasHirt
Copy link
Collaborator

LukasHirt commented Dec 27, 2024

Even with the web PR using as the web build (confirmed by seeing the webdav in the URL) I still am seeing errors with public links.

image

The first response does not really return anything useful in the response. The second one returns this:

message: "Invalid response: No root multistatus found"

For full picture: this is the version of oCIS I tested this with 7.0.0-rc.3+75b71766a

@dschmidt dschmidt force-pushed the refactor/switch-to-upstream-uppy branch from ee9d1ff to 1e778f1 Compare December 30, 2024 10:05
@LukasHirt
Copy link
Collaborator

The error mentioned above is not related to this change but to a different url when using oCIS. (ref #127)

@LukasHirt LukasHirt marked this pull request as ready for review January 16, 2025 10:11
@LukasHirt LukasHirt merged commit 91aad11 into main Jan 16, 2025
2 checks passed
@LukasHirt LukasHirt deleted the refactor/switch-to-upstream-uppy branch January 16, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants