Conversation
dschmidt
requested review from
fschade,
kulmann and
pascalwengerter
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
approved these changes
Dec 13, 2021
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Thanks for bringing in some consistency 👍
kulmann
reviewed
Dec 13, 2021
| }, | ||
| methods: { | ||
| $_fetch_trigger({ resources, mimeType, isPublicFile }) { | ||
| let url; |
Contributor
There was a problem hiding this comment.
linter complained about this semicolon, you can just drop it
Contributor
|
Results for oCISRename https://drone.owncloud.com/owncloud/web/20940/53/1 |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When #4615 was created, using "open in browser" on public links indeed resulted in the described behavior.
In #4689 the behavior was changed to open the download url in a new tab, that in turn did not open the file in the browser (for me, Chromium 95) but instead downloaded it with a random/hash filename.
The code path for private files achieves the correct result: it opens the file in a new tab and displays it.
We can align the behavior for public files with that by simply using the downloadUrl in the XHR download.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: