[full-ci] Multiple fixes#6618
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Still need to have a look at the tests |
|
hey @diocas could you run |
| computed: { | ||
| ...mapGetters('Files', ['highlightedFile']), | ||
| ...mapGetters(['getToken', 'capabilities']), | ||
| ...mapGetters(['getToken', 'capabilities', 'isOcis']), |
There was a problem hiding this comment.
The isOcis helper has been removed in #6619 in favour of checking the resharing capability - do you mind looking into the usage of that? it needs to be used in a setup call (composition api).
There was a problem hiding this comment.
I do not understand what you asked, sorry. I've replaced with just a check from a capability.
|
|
||
| static list(isFolder: boolean): ShareRole[] { | ||
| return this.all.filter((r) => r.folder === isFolder) | ||
| static list(isFolder: boolean, isOcis: boolean = false): ShareRole[] { |
There was a problem hiding this comment.
Can you rename that usage of isOcis to a capability?
There was a problem hiding this comment.
I've changed to capabilities.files_sharing?.public?.can_edit is this ok?
|
Sorry for the linting.. Don't know how I forgot. |
diocas
force-pushed
the
multiple_fixes
branch
2 times, most recently
from
f6a0b67 to
265e02f
Compare
|
@kulmann I think the test got stuck, can you run them again? (I think I've "fixed" the issues, ofc the additions still need proper testing) |
| const store = new Vuex.Store({ | ||
| getters: { | ||
| capabilities: () => { | ||
| return {} |
There was a problem hiding this comment.
My gripe with this is that it doesn't check the newly added logic via this.capabilities?.files?.permanent_deletion (as in it should now test both cases, one where permanent_deletion is true and one where it's false)
There was a problem hiding this comment.
Yes, I mentioned it above. I can try to add some tests, but not sure when.
Only available in oCIS
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/24057/71/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIPrivateLinks-accessingPrivateLinks_feature-L17.png |
|
Kudos, SonarCloud Quality Gate passed!
|
5 participants
As we discussed, I'm trying to push some of our changes, in particular I refactored the code to make some parts optional.
Renaming a share, permanently deleting files and showing the custom permissions role are now optional. By default, it keeps the same behavior as the current master.
Added the possibility to add "tags" while searching for users (as we discussed).
Also as discussed, I've added the "editor" role for single files public links. This seems not to be possible with oc10, so I've added a check to enable it only for oCIS.
(this needs another fix... I saw the "rename" button on the file and I shouldn't, but at least if fails when I tried to do it)
@elizavetaRa is still working on the css for the drop down menus.
Fixes #6324
Fixes #5913