[full-ci] Use resharing capability instead of hardcoding isOcis#6619
Merged
[full-ci] Use resharing capability instead of hardcoding isOcis#6619
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
resharing_capability
branch
from
62b949f to
53d410e
Compare
Contributor
|
Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23848/69/1
|
Contributor
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23848/67/1
|
kulmann
suggested changes
Mar 18, 2022
Contributor
|
can you please rebase? there are conflicts now. and #6577 has been merged with additional |
dschmidt
force-pushed
the
resharing_capability
branch
from
53d410e to
7161e33
Compare
dschmidt
force-pushed
the
resharing_capability
branch
from
7161e33 to
4727611
Compare
Contributor
|
Results for oCISBasic https://drone.owncloud.com/owncloud/web/23894/51/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIAccount-accountInformation_feature-L10.png |
dschmidt
force-pushed
the
resharing_capability
branch
from
21c63f8 to
dc07cc7
Compare
dschmidt
force-pushed
the
resharing_capability
branch
from
dc07cc7 to
403a128
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the not-so-granular
isOcisgetter (which relies onedition === 'reva') by composables which in turn read capabilities from the store.Related Issue
Motivation and Context
The
edition === 'reva'check blocks owncloud/ocis#2918How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: