Read only disks, no size limit on local disks by david-crespo · Pull Request #3021 · oxidecomputer/console

david-crespo · 2026-01-30T18:43:34Z

Threw this together real quick to de-risk and get a sense of the vibes. API built from oxidecomputer/omicron#9731, which isn't merged yet and we're not sure if it will make it in for v18. This is built on top of #3005 because that has earlier API changes in it.

Fun questions

I put the read-only badge right in the name cell because it would be excessive to give it its own column, but really it doesn't feel great there either. Maybe if we had a read-only icon that you could hover on to get a label, it would work better in the name cell.
Read only: Yes in the side modal looks silly, also not as grouped together with snapshot ID as I would like.
Copy for the checkbox label (and possibly help text) — "Make disk read-only" is weird, as Ben points out

vercel · 2026-01-30T18:43:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
console	Ready	Preview	Feb 5, 2026 10:14pm

benjaminleonard · 2026-01-30T18:45:38Z

app/components/StateBadge.tsx

+
+export const ReadOnlyBadge = () => (
+  <Badge color="neutral" className="relative">
+    read only


Such a silly nit, but I feel like even if it's made uppercase its good practice to case them properly

benjaminleonard · 2026-01-30T18:45:59Z

app/forms/disk-create.tsx

+            <SnapshotSelectField control={control} />
+            <div className="mt-2">
+              <CheckboxField name="diskBackend.diskSource.readOnly" control={control}>
+                Make disk read-only


"Make disk" is strange? Maybe just "Read-only"

I put that in there tentatively because when it was just read-only, it wasn't clear enough that read-only refers to the resulting disk. So I think we need something more than read-only. Unless we just make the label "Read only" and we put help text in there that says "Instances won't be able to write to this disk" or something. I am also slightly torn about the hyphen. Generally I feel like hyphen is right for regular copy, but when it's just "Read-only" by itself it looks bad.

benjaminleonard · 2026-01-30T18:48:41Z

Are there consequences to this action we want to communicate after the user has checked the box? Do we need to clarify that it cannot edited later?

benjaminleonard · 2026-01-30T19:01:18Z

Scattergun thoughts contd:

Can you use it for boot disks, or just additional ones?
1a. If you can, how does cloud init work?
Will it always just be for snapshots? Or images too?

david-crespo · 2026-01-30T19:31:47Z

Yes, can boot — sounds like this is the main use case
a. Great question. @hawkw is checking. Edit: the cloud init volume is its own PCI device and should not be affected by the boot disk being read only.
Images coming in like one hour lol

david-crespo · 2026-01-30T20:15:11Z

Further update on cloud-init: because cloud-init is fundamentally a program that runs in the guest OS and pulls data from the CIDATA volume, they just have to not do that (chat).

hawkw · 2026-01-30T20:22:09Z

@benjaminleonard:

Are there consequences to this action we want to communicate after the user has checked the box? Do we need to clarify that it cannot edited later?

I'd like to add some stuff to the docs about read-only disks, perhaps the checkbox should have a link to there?

@david-crespo:

Images coming in like one hour lol

As of oxidecomputer/omicron@4c3bd6b, it should also be an option for DiskSource::Image (slightly less than an hour lol). :)

hawkw · 2026-02-02T17:49:37Z

@david-crespo https://github.com/oxidecomputer/docs/pull/717 adds some documentation on read-only disks, if you want to link to that from the disk create modal?

david-crespo · 2026-02-02T22:33:21Z

Added a read only checkbox to boot disk on the instance create form.

david-crespo · 2026-02-03T17:51:13Z

Was able to repro the e2e flakes from 4b2594f locally with these commands

npm run e2e -- --project=chrome  --repeat-each 20 -g 'Create local disk with size > 1023 GiB'
npm run e2e -- --project=chrome  --repeat-each 20 -g 'Distributed disk clamps'
npm run e2e -- --project=firefox --repeat-each 20 -g 'Local disk has no max size limit'

and thereby confirm that the fixes in 0034210 work.

benjaminleonard · 2026-02-04T17:32:56Z

The SSH key issue we can handle separately, will make an issue.

Read only badge in the table seems like the best of the options available, prefer to polluting the table with another column.

Read only: yes is weird. But not sure how to improve that whilst being honest about the API. If underneath we had "Read" and "Read and Write" as an access type that would feel more comfortable. Read only: True?

"Read-only" on its own is confusing when next to the listbox and moving it out of that container would probably require its own title. Again if the API was different we could use radios with the default being "Read and Write".

david-crespo · 2026-02-04T19:14:21Z

TRUE and FALSE as badges could work?

hawkw · 2026-02-05T00:14:05Z

TRUE and FALSE as badges could work?

RW and RO are very horizontal-space-efficient...you could even be overly cute and do rwx and r-x like in ls output but that's probably a bit weird since we don't have an equivalent to the "execute" bit...

benjaminleonard · 2026-02-05T12:47:05Z

RW and RO are very horizontal-space-efficient...you could even be overly cute and do rwx and r-x like in ls output but that's probably a bit weird since we don't have an equivalent to the "execute" bit...

Space I'm less concerned about since the tables overflow — I just think representing boolean values in UI can be less clear than an enum. I suspect RW and RO might confuse people and I've never learned the ls output haha. We generally try to match the API.

TRUE and FALSE as badges could work?

I don't hate it, but we'd want to move the column along. Since this is going to be false 99% of the time, having it earlier seems like a waste of more valuable early column space.

hawkw · 2026-02-05T20:51:33Z

RW and RO are very horizontal-space-efficient...you could even be overly cute and do rwx and r-x like in ls output but that's probably a bit weird since we don't have an equivalent to the "execute" bit...

Space I'm less concerned about since the tables overflow — I just think representing boolean values in UI can be less clear than an enum. I suspect RW and RO might confuse people and I've never learned the ls output haha. We generally try to match the API.

TRUE and FALSE as badges could work?

I don't hate it, but we'd want to move the column along. Since this is going to be false 99% of the time, having it earlier seems like a waste of more valuable early column space.

have we thought about just leaving the READ ONLY column blank when the disk is read/write? the FALSE FALSE FALSE FALSE feels kinda eye-hurty to me

david-crespo · 2026-02-05T22:50:09Z

Went with true/false badge in the side modal. Keeping it in the name cell in the tables.

vercel bot deployed to Preview January 30, 2026 18:43 View deployment

benjaminleonard reviewed Jan 30, 2026

View reviewed changes

vercel bot deployed to Preview January 30, 2026 22:33 View deployment

david-crespo force-pushed the read-only-disks branch from 076ea6d to 132ec65 Compare February 2, 2026 22:32

vercel bot deployed to Preview February 2, 2026 22:33 View deployment

vercel bot deployed to Preview February 3, 2026 05:24 View deployment

david-crespo changed the title ~~Read only disks~~ Read only disks, no size limit on local disks Feb 3, 2026

david-crespo force-pushed the read-only-disks branch from 4b2594f to 0034210 Compare February 3, 2026 17:49

vercel bot deployed to Preview February 3, 2026 17:50 View deployment

david-crespo marked this pull request as ready for review February 3, 2026 18:04

Base automatically changed from ipv6_migration to main February 5, 2026 20:24

david-crespo force-pushed the read-only-disks branch from 0034210 to bac1aec Compare February 5, 2026 20:29

vercel bot deployed to Preview February 5, 2026 20:29 View deployment

vercel bot deployed to Preview February 5, 2026 20:54 View deployment

bump API for read-only disks

1b9d6f1

david-crespo added 10 commits February 5, 2026 14:55

read-only disks UI

b63ce8b

add read only checkbox to instance create boot disk

9e1289b

better types in disk create form

e5a78c8

remove size limit for local disks

4ac5e43

debug-e2e skill + fix flake in disk size cap tests

88a6cf6

bump API one more time

3667e53

formatting. are you kidding me

45bad7e

read only: true/false badge in side modal

fb2326e

tweaks

dafd250

fix min/minSize confusion

149943c

david-crespo force-pushed the read-only-disks branch from 3814fc8 to 149943c Compare February 5, 2026 22:02

vercel bot deployed to Preview February 5, 2026 22:03 View deployment

fix read only badge in name cell not being clickable

ad9fb17

vercel bot deployed to Preview February 5, 2026 22:14 View deployment

david-crespo merged commit 948c1d3 into main Feb 5, 2026
7 checks passed

david-crespo deleted the read-only-disks branch February 5, 2026 22:50

david-crespo mentioned this pull request Feb 5, 2026

Bump web console (ipv6 + read-only disks) oxidecomputer/omicron#9805

Merged

Conversation

david-crespo commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fun questions

Uh oh!

vercel bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminleonard Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

benjaminleonard Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

david-crespo Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

benjaminleonard commented Jan 30, 2026

Uh oh!

benjaminleonard commented Jan 30, 2026

Uh oh!

david-crespo commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-crespo commented Jan 30, 2026

Uh oh!

hawkw commented Jan 30, 2026

Uh oh!

hawkw commented Feb 2, 2026

Uh oh!

david-crespo commented Feb 2, 2026

Uh oh!

david-crespo commented Feb 3, 2026

Uh oh!

benjaminleonard commented Feb 4, 2026

Uh oh!

david-crespo commented Feb 4, 2026

Uh oh!

hawkw commented Feb 5, 2026

Uh oh!

benjaminleonard commented Feb 5, 2026

Uh oh!

hawkw commented Feb 5, 2026

Uh oh!

david-crespo commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-crespo commented Jan 30, 2026 •

edited

Loading

vercel bot commented Jan 30, 2026 •

edited

Loading

david-crespo commented Jan 30, 2026 •

edited

Loading