Skip to content

Rename packrat field names #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesmunns merged 2 commits into from
Sep 3, 2026
+10 −12
Merged

Rename packrat field names #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37eaefd
Rename packrat field names
jamesmunns Sep 3, 2026
6d69f52
Version update
jamesmunns Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions cmd/host/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,10 @@ static HOST_STATE_BUF_NAME_2: &str =
static PACKRAT_BUF_NAME: &str = "task_packrat::main::BUFS";

// packrat field names
const PACKRAT_LAST_PANIC_PAYLOAD: &str =
"cell.value.host_info.host_panic_payload";
const PACKRAT_LAST_PANIC_STATE: &str = "cell.value.host_info.host_panic_state";
const PACKRAT_BOOT_FAIL_PAYLOAD: &str =
"cell.value.host_info.host_panic_payload";
const PACKRAT_BOOT_FAIL_STATE: &str = "cell.value.host_info.host_panic_state";
const PACKRAT_LAST_PANIC_PAYLOAD: &str = "cell.value.host_info.panic_payload";
const PACKRAT_LAST_PANIC_STATE: &str = "cell.value.host_info.panic_state";
const PACKRAT_BOOT_FAIL_PAYLOAD: &str = "cell.value.host_info.panic_payload";
const PACKRAT_BOOT_FAIL_STATE: &str = "cell.value.host_info.panic_state";

@adamlouis adamlouis Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmunns are there tests we can add to catch issues like these moving forward?

@jamesmunns jamesmunns Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll add an issue to add this to our regression test suite. We have tests for older versions, but I didn't add one as we hadn't landed the hubris change yet when the humility PR did (which also fixed some other issues).

@jamesmunns jamesmunns Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #729


/// Mirror type of the internal buf struct in `host_sp_comms`. Must be kept in
/// (partial) sync with that structure (fields that are present need to match,
Expand Down
2 changes: 1 addition & 1 deletion humility-bin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
[package]
name = "humility-bin"
edition.workspace = true
version = "0.13.8"
version = "0.13.9"
license = "MPL-2.0"

[build-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions humility-bin/tests/cmd/chip.trycmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ For more information, try '--help'.

```
$ humility --chip this-can-be-anything -V
humility 0.13.8
humility 0.13.9

```

Expand All @@ -28,6 +28,6 @@ For more information, try '--help'.

```
$ humility -c apx432 -V
humility 0.13.8
humility 0.13.9

```
4 changes: 2 additions & 2 deletions humility-bin/tests/cmd/version.trycmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ Long version flag:

```
$ humility --version
humility 0.13.8
humility 0.13.9

```

Short version flag:

```
$ humility -V
humility 0.13.8
humility 0.13.9

```
Loading